Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: use one level accordions for items inside the right pane #71

Open
1 task done
harish-sethuraman opened this issue Oct 20, 2024 · 4 comments · May be fixed by #72
Open
1 task done

Suggestion: use one level accordions for items inside the right pane #71

harish-sethuraman opened this issue Oct 20, 2024 · 4 comments · May be fixed by #72
Assignees
@harish-sethuraman
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion enhancement New feature or request

Comments

@harish-sethuraman
Copy link
Member

What problem do you want to solve?

Currently there are two levels of accordion for values inside the tree. We might want to reduce it to one level. I don't see a necessity for having two levels of accordion. We can possibly remove the accordion inside and replace it with the + and - similar to astexplorer. This way it would be easier for us to enable the auto opening of accordions on right pane based on active line in left panel (ref). Raised this issue to understand if we are benefiting anything over having two levels of accordions.

What do you think is the correct solution?

  • find why we have two accordions
  • replace two levels of accordion with just one level

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response
@harish-sethuraman harish-sethuraman added the enhancement New feature or request label Oct 20, 2024
@nzakas
Copy link
Member

nzakas commented Oct 21, 2024

I'm guessing this is because we still wanted to have the heading on each object. Can you share an image of how you'd imagine changing this?

@harish-sethuraman
Copy link
Member Author

This is how it looks without the accordion. The type information is already present on the expandable header on top.

Image

@nzakas
Copy link
Member

nzakas commented Oct 23, 2024

To me that looks kind of broken. Could we remove the accordion but keep the same visual treatment we currently have? (With a header that doesn't expand/collapse?)

@harish-sethuraman
Copy link
Member Author

Sure that is possible. I'll make it default open and remove the accordion interaction from there.

@harish-sethuraman harish-sethuraman added the accepted There is consensus among the team that this change meets the criteria for inclusion label Oct 24, 2024
@harish-sethuraman harish-sethuraman self-assigned this Oct 24, 2024
@harish-sethuraman harish-sethuraman linked a pull request Oct 28, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harish-sethuraman harish-sethuraman

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move accordion to one level eslint/code-explorer
2 participants
@nzakas @harish-sethuraman