Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Distinguish between formatting and code-quality rules #736

Open
pubmikeb opened this issue Jun 6, 2020 · 6 comments
Open

Distinguish between formatting and code-quality rules #736

pubmikeb opened this issue Jun 6, 2020 · 6 comments
Labels
demo Relates to the ESLint demo page (https://eslint.org/demo) enhancement This change enhances an existing feature of the website

Comments

@pubmikeb
Copy link

pubmikeb commented Jun 6, 2020

The version of ESLint you are using.
7.2.0

The problem you want to solve.
Following the issue eslint/eslint#13348, currently Rules Configuration tool contains a long mixed list of rules, which contains both formatting and code-quality rules all together.

Your take on the correct solution to problem.
It's better to separate these rules into two categories:

  • formatting rules
  • code-quality rules

This will simplify the rules management and housekeeping, and will allow easily to delegate code-quality linting to ESLint and rely on Prettier for formatting tasks.

Are you willing to submit a pull request to implement this change?
No.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jun 6, 2020
@kaicataldo kaicataldo added demo Relates to the ESLint demo page (https://eslint.org/demo) enhancement This change enhances an existing feature of the website and removed triage An ESLint team member will look at this issue soon labels Jun 6, 2020
@kaicataldo
Copy link
Member

Agreed that separating the rules into categories would make the list easier to grok. I think we should group them by the categories in their metadata (similar to https://eslint.org/rules), which should be a fairly simple task!

@pubmikeb
Copy link
Author

pubmikeb commented Jun 6, 2020

Category in the metadata (https://eslint.org/docs/rules/) is good, but the main idea of this issue is to be able to select all code-quality rules with one click and download the config file withouth reading of metadata of all 100+ rules.

@nzakas
Copy link
Member

nzakas commented Jun 8, 2020

I'd like to separate the rules into just three headings: errors, suggestions, and style. Those are already encoded in the rule meta data and I think makes more sense that the category headings we have now.

@pubmikeb
Copy link
Author

pubmikeb commented Jun 8, 2020

@nzakas, great idea, I would also add separation to current (supported) and deprecated rules.

@nzakas
Copy link
Member

nzakas commented Jun 8, 2020

Yeah, I think we’d keep deprecated rules as-is, one list of all of them.

@pubmikeb
Copy link
Author

pubmikeb commented Jun 8, 2020

The key idea is to be able to unselect all deprecated rules with one click to not include them into a config.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
demo Relates to the ESLint demo page (https://eslint.org/demo) enhancement This change enhances an existing feature of the website
Projects
None yet
Development

No branches or pull requests

3 participants