Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace: any changes to the Pattern or Replacement fields are not saved unless "Run" is clicked #650

Open
elfeon-g opened this issue Aug 20, 2024 · 2 comments
Labels

Comments

@elfeon-g
Copy link

Hi,

I remember that before the Replace add-on was overhauled (when the appearance of the pop-up changed — by the way, tangentially, why the underline...? I don't really mind the updated look, I just can't fathom why there's an underline on the text in the fields now. but anyway), I could simply e.g. copy something from the page, go paste it in one of the fields, click away from the extension to copy something else and go paste it in the other field and it worked just fine.

But ever since that update happened, every time I click away from the add-on and the pop-up disappears, any changes I've made to the text in the Pattern/Replacement fields are undone. So I can't copy/paste stuff from the page into the add-on multiple times, I have to enter everything in one go or it won't be saved.

This has been kind of a nuisance for a while now, especially since it used to work in the old version :( It just didn't really cross my mind that I could try finding somewhere to send feedback haha. Thank you for making the add-on regardless!

@erosman
Copy link
Owner

erosman commented Aug 20, 2024

why the underline.

To show if there are spaces, as it caused confusion (unexpected results) e.g. when there where spaces at the end of the pattern.

But ever since that update happened, every time I click away from the add-on and the pop-up disappears, any changes I've made to the text in the Pattern/Replacement fields are undone. So I can't copy/paste stuff from the page into the add-on multiple times, I have to enter everything in one go or it won't be saved.

The reason was to avoid errors e.g. when people paste unexpected text and clear previous pattern.

However, if there is a popular demand, I can change the save behaviour.

@elfeon-g
Copy link
Author

Thank you for the reply! The reason for underline thing makes sense, I hadn't thought about that lol.

The reason was to avoid errors e.g. when people paste unexpected text and clear previous pattern.

For that kind of error though, personally my first instinct would be to try Ctrl/Cmd+Z, not to close the window? I just tried it and it does work within the text field too.

Also, honestly, the first place I looked once I noticed this new behavior was the options, just in case there was something there. So if a toggle's not too much work, maybe it could be added as an option — wouldn't bloat anything much, considering there's only one right now x)
In any case, at least I'm glad it was an intended change and not some consequence of a bug that you'd have to track down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants