fix ErgoStateContextSpec sporadic failure

fix test 'valid application of correct extension'

fix test 'validation of field value sizes'

Author: stenolog

src/test/scala/org/ergoplatform/nodeView/state/ErgoStateContextSpec.scala

@@ -58,13 +58,27 @@ class ErgoStateContextSpec extends HistoryTestHelpers {
       fb.copy(extension = newExtension)
     }
 
+    // regression stress-test for sporadic failure https://github.com/ergoplatform/ergo/issues/2114
+    // disabling for now
+    // for (i <- 1 to 1000) {
+    // printf("\r%d05 ", i)
+
     // checks, specific for extension
     // validation of field keys size
     val imvKey = extensionKvGen(Extension.FieldKeySize - 1, Extension.FieldValueMaxSize).sample.get
     sc.appendFullBlock(fbWithFields(imvKey +: oldFields)) shouldBe 'failure
 
+    // https://github.com/ergoplatform/ergo/issues/2114
+    // this fails sporadically, when `(imvValue._1.head == 0)`, because less value bytes will be generated
+    // by extensionKvGen(). Workaround is to just generate again while `(imvValue._1.head == 0)`
+    // TODO: document, and possibly rewrite extensionKvGen after the above issues are clarified/solved
+    //       https://github.com/ergoplatform/ergo/issues/2118
+
     // validation of field value sizes
-    val imvValue = extensionKvGen(Extension.FieldKeySize, Extension.FieldValueMaxSize + 1).sample.get
+    var imvValue = extensionKvGen(Extension.FieldKeySize, Extension.FieldValueMaxSize + 1).sample.get
+    while (imvValue._1.head == 0) {
+        imvValue = extensionKvGen(Extension.FieldKeySize, Extension.FieldValueMaxSize + 1).sample.get
+    }
     sc.appendFullBlock(fbWithFields(imvValue +: oldFields)) shouldBe 'failure
 
     // validation of incorrect interlinks
@@ -73,13 +87,23 @@ class ErgoStateContextSpec extends HistoryTestHelpers {
     ).fields
     sc.appendFullBlock(fbWithFields(invalidInterlinks ++ oldFields)) shouldBe 'failure
 
+    // https://github.com/ergoplatform/ergo/issues/2114
+    // if validMKV._1.head is 1, appendFullBlock within "valid application of correct extension" will fail
+    // As a workaround, just generate new values until (validMKV._1.head != 1)
+    // TODO: investigate and provide a full fix (followup issue)
+    //       https://github.com/ergoplatform/ergo/issues/2117
+    var validMKV = extensionKvGen(Extension.FieldKeySize, Extension.FieldValueMaxSize).sample.get
+    while (validMKV._1.head == 1) {
+      validMKV = extensionKvGen(Extension.FieldKeySize, Extension.FieldValueMaxSize).sample.get
+    }
     // validation of key duplicates in fields
-    val validMKV = extensionKvGen(Extension.FieldKeySize, Extension.FieldValueMaxSize).sample.get
     sc.appendFullBlock(fbWithFields(Seq(validMKV, validMKV) ++ oldFields)) shouldBe 'failure
 
     // valid application of correct extension
     sc.appendFullBlock(fbWithFields(validMKV +: oldFields)) shouldBe 'success
 
-  }
+    }
+
+  //} // test-loop
 
 }