Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Token List Arrangement #171

Open
ErgoTester opened this issue May 21, 2023 · 4 comments
Open

New Token List Arrangement #171

ErgoTester opened this issue May 21, 2023 · 4 comments

Comments

@ErgoTester
Copy link

Split Token List To 3 Parts:

1- Tokens
2- NFTs
3- Audio NFTs

Tho it could be 2 Parts Tokens and NFTs, 3 parts would be better

@MrStahlfelge
Copy link
Member

This was meant to be on the send screen when adding tokens, do I remember correct?

@MrStahlfelge
Copy link
Member

MrStahlfelge commented Jun 3, 2023

This can be done both on send list and on wallet details screen by adding a filter icon button with an action menu: all tokens/images/audio/video/(others can be added). Selecting something else than all filters the list.

To do:

  • add the filter to send tokens list Android
  • same for desktop
  • same for ios
  • add the filter to wallet details screen Android
  • same for desktop
  • same for ios

@ErgoTester
Copy link
Author

yes both screens
why use filter button ? doesn't that create unnecessary extra steps ?
i was thinking something like this
Untitled

@MrStahlfelge
Copy link
Member

why use filter button ? doesn't that create unnecessary extra steps ?

That depends on your mix and number of tokens. If you have a lot of tokens, filtering will reduce the number of tokens to choose from which can be an advantage. The splitting you suggested is better if you have a small number of tokens, ultimately it is nothing else than another sorting (sorting by token type first, sorting by name second) with subheadings.
I don't see much issues with a small number of tokens with the current implementation as image/audio/video are clearly emphasized by a badge. So I think it is more important to improve the situation for wallets with a lot of tokens. A filter was also already suggested (by PM, not in a GH issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants