bug fix; pylint and flake8 fixes

Author: snowman2

.pylintrc

@@ -1,2 +1,4 @@
 [MESSAGES CONTROL]
-disable=invalid-name, bad-continuation, too-many-lines, superfluous-parens, too-many-arguments, too-many-branches, too-many-statements, too-many-locals
+disable=invalid-name,bad-continuation,too-many-lines,superfluous-parens,too-many-arguments,too-many-branches,too-many-statements,too-many-locals,too-few-public-methods,too-many-instance-attributes
+[TYPECHECK]
+ignored-modules=numpy,netCDF4,scipy,scipy.spatial

RAPIDpy/__init__.py

@@ -1,3 +1,9 @@
 # -*- coding: utf-8 -*-
-from .rapid import RAPID
-from .dataset import RAPIDDataset
+"""
+    RAPIDpy
+
+    Created by Alan D Snow, 2015.
+    License: BSD 3-Clause
+"""
+from .rapid import RAPID  # noqa
+from .dataset import RAPIDDataset  # noqa

RAPIDpy/dataset.py

@@ -9,7 +9,7 @@
 from csv import writer as csv_writer
 import datetime
 
-from netCDF4 import Dataset, num2date  # pylint: disable=no-name-in-module
+from netCDF4 import Dataset, num2date
 import numpy as np
 from numpy.ma import is_masked
 import pandas as pd

RAPIDpy/gis/muskingum.py

@@ -117,7 +117,7 @@ def CreateMuskingumKfacFile(in_drainage_line,
 
     number_of_features = ogr_drainage_line_shapefile_lyr.GetFeatureCount()
     river_id_list = np.zeros(number_of_features, dtype=np.int32)
-    # pylint: disable=no-member
+
     length_list = \
         np.zeros(number_of_features, dtype=np.float32)
     slope_list = np.zeros(number_of_features, dtype=np.float32)

RAPIDpy/gis/voronoi.py

@@ -10,7 +10,7 @@
 
 import numpy as np
 from osgeo import ogr, osr
-from scipy.spatial import Voronoi  # pylint: disable=no-name-in-module
+from scipy.spatial import Voronoi
 from shapely.geometry import Polygon
 
 from ..helper_functions import log

RAPIDpy/gis/weight.py

@@ -11,7 +11,7 @@
 from datetime import datetime
 from functools import partial
 
-from netCDF4 import Dataset  # pylint: disable=no-name-in-module
+from netCDF4 import Dataset
 import numpy as np
 from pyproj import Proj, transform
 from shapely.wkb import loads as shapely_loads

RAPIDpy/helper_functions.py

@@ -11,7 +11,7 @@
 
 from numpy.testing import assert_almost_equal
 from numpy import array as np_array
-from numpy import float32 as np_float32  # pylint: disable=no-name-in-module
+from numpy import float32 as np_float32
 
 
 # -----------------------------------------------------------------------------
@@ -121,3 +121,16 @@ def remove_files(*args):
             remove(arg)
         except OSError:
             pass
+
+
+def add_latlon_metadata(lat_var, lon_var):
+    """Adds latitude and longitude metadata"""
+    lat_var.long_name = 'latitude'
+    lat_var.standard_name = 'latitude'
+    lat_var.units = 'degrees_north'
+    lat_var.axis = 'Y'
+
+    lon_var.long_name = 'longitude'
+    lon_var.standard_name = 'longitude'
+    lon_var.units = 'degrees_east'
+    lon_var.axis = 'X'

RAPIDpy/inflow/CreateInflowFileFromERAInterimRunoff.py

@@ -7,7 +7,7 @@
    Adapted from CreateInflowFileFromECMWFRunoff.py.
    License: BSD-3-Clause
 """
-from netCDF4 import Dataset  # pylint: disable=no-name-in-module
+from netCDF4 import Dataset
 
 from .CreateInflowFileFromGriddedRunoff import \
     CreateInflowFileFromGriddedRunoff

RAPIDpy/inflow/CreateInflowFileFromGriddedRunoff.py

@@ -6,13 +6,12 @@
    Created by Alan D. Snow, 2016
    License: BSD-3-Clause
 """
-# pylint: disable=no-member
 from abc import abstractmethod
 import csv
 from datetime import datetime
 import os
 
-from netCDF4 import Dataset  # pylint: disable=no-name-in-module
+from netCDF4 import Dataset
 import numpy as np
 from pytz import utc
 from past.builtins import xrange  # pylint: disable=redefined-builtin
@@ -32,6 +31,7 @@ class CreateInflowFileFromGriddedRunoff(object):
     header_wt = ['rivid', 'area_sqm', 'lon_index', 'lat_index', 'npoints']
 
     def __init__(self):
+        self.runoff_vars = []
         self.dict_list = []
         self.count = 0
         self.size_stream_id = 0

RAPIDpy/inflow/CreateInflowFileFromLDASRunoff.py

@@ -7,7 +7,7 @@
    Adapted from CreateInflowFileFromECMWFRunoff.py.
    License: BSD-3-Clause
 """
-from netCDF4 import Dataset  # pylint: disable=no-name-in-module
+from netCDF4 import Dataset
 
 from .CreateInflowFileFromGriddedRunoff import \
     CreateInflowFileFromGriddedRunoff