quote entire custom claims object and escape inner quotes (firebase#5630)

* quote entire custom claims object and escape inner quotes

---------

Co-authored-by: Thomas Burke <[email protected]>
Co-authored-by: joehan <[email protected]>

Author: thomasmburke

CHANGELOG.md

@@ -1 +1,2 @@
 - Releases Cloud Firestore emulator v1.16.1, which adds support for read_time in ListCollectionIds.
+- Fixes auth:export with csv format for users with custom claims. (#3319)

src/accountExporter.ts

@@ -84,7 +84,10 @@ function transUserToArray(user: any): any[] {
   arr[24] = user.lastLoginAt;
   arr[25] = user.phoneNumber;
   arr[26] = user.disabled;
-  arr[27] = user.customAttributes;
+  // quote entire custom claims object and escape inner quotes with quotes
+  arr[27] = user.customAttributes
+    ? `"${user.customAttributes.replace(/(?<!\\)"/g, '""')}"`
+    : user.customAttributes;
   return arr;
 }
 

src/test/accountExporter.spec.ts

@@ -62,42 +62,7 @@ describe("accountExporter", () => {
     });
 
     it("should call api.request multiple times for JSON export", async () => {
-      nock("https://www.googleapis.com")
-        .post("/identitytoolkit/v3/relyingparty/downloadAccount", {
-          maxResults: 3,
-          targetProjectId: "test-project-id",
-        })
-        .reply(200, {
-          users: userList.slice(0, 3),
-          nextPageToken: "3",
-        })
-        .post("/identitytoolkit/v3/relyingparty/downloadAccount", {
-          maxResults: 3,
-          nextPageToken: "3",
-          targetProjectId: "test-project-id",
-        })
-        .reply(200, {
-          users: userList.slice(3, 6),
-          nextPageToken: "6",
-        })
-        .post("/identitytoolkit/v3/relyingparty/downloadAccount", {
-          maxResults: 3,
-          nextPageToken: "6",
-          targetProjectId: "test-project-id",
-        })
-        .reply(200, {
-          users: userList.slice(6, 7),
-          nextPageToken: "7",
-        })
-        .post("/identitytoolkit/v3/relyingparty/downloadAccount", {
-          maxResults: 3,
-          nextPageToken: "7",
-          targetProjectId: "test-project-id",
-        })
-        .reply(200, {
-          users: [],
-          nextPageToken: "7",
-        });
+      mockAllUsersRequests();
 
       await serialExportUsers("test-project-id", {
         format: "JSON",
@@ -216,7 +181,7 @@ describe("accountExporter", () => {
       expect(nock.isDone()).to.be.true;
     });
 
-    it("should export a user's custom attributes", async () => {
+    it("should export a user's custom attributes for JSON formats", async () => {
       userList[0].customAttributes =
         '{ "customBoolean": true, "customString": "test", "customInt": 99 }';
       userList[1].customAttributes =
@@ -244,6 +209,33 @@ describe("accountExporter", () => {
       expect(nock.isDone()).to.be.true;
     });
 
+    it("should export a user's custom attributes for CSV formats", async () => {
+      userList[0].customAttributes =
+        '{ "customBoolean": true, "customString": "test", "customInt": 99 }';
+      userList[1].customAttributes = '{ "customBoolean": true }';
+      nock("https://www.googleapis.com")
+        .post("/identitytoolkit/v3/relyingparty/downloadAccount", {
+          maxResults: 3,
+          targetProjectId: "test-project-id",
+        })
+        .reply(200, {
+          users: userList.slice(0, 3),
+        });
+      await serialExportUsers("test-project-id", {
+        format: "JSON",
+        batchSize: 3,
+        writeStream: writeStream,
+      });
+      expect(spyWrite.getCall(0).args[0]).to.eq(JSON.stringify(userList[0], null, 2));
+      expect(spyWrite.getCall(1).args[0]).to.eq(
+        "," + os.EOL + JSON.stringify(userList[1], null, 2)
+      );
+      expect(spyWrite.getCall(2).args[0]).to.eq(
+        "," + os.EOL + JSON.stringify(userList[2], null, 2)
+      );
+      expect(nock.isDone()).to.be.true;
+    });
+
     function mockAllUsersRequests(): void {
       nock("https://www.googleapis.com")
         .post("/identitytoolkit/v3/relyingparty/downloadAccount", {