Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SIMULATION_JOB #4955

Open
oysteoh opened this issue Feb 24, 2023 · 3 comments · May be fixed by #9606
Open

Remove SIMULATION_JOB #4955

oysteoh opened this issue Feb 24, 2023 · 3 comments · May be fixed by #9606
Assignees
@DanSava

Comments

@oysteoh
Copy link
Contributor

oysteoh commented Feb 24, 2023 •
edited
Loading

If possible, we should get rid of this keyword. We know everest is using it, but are there others?
First step - figure out if it is used outside everest.
@oysteoh oysteoh converted this from a draft issue Feb 24, 2023
@oysteoh oysteoh changed the title Investigate possibility of removing new_style/SIMULATION_JOB Add a log-statement for new_style/SIMULATION_JOB Mar 27, 2023
@oysteoh oysteoh moved this from Todo to Backlog in SCOUT Mar 30, 2023
@sondreso
Copy link
Collaborator

Just to point out the obvious other uses:

ert/test-data/poly_example/poly.ert

Line 18 in 66a8030

SIMULATION_JOB poly_eval

@eivindjahren eivindjahren moved this from Backlog to Todo in SCOUT Jan 29, 2024
@eivindjahren eivindjahren moved this from Todo to Backlog in SCOUT Feb 13, 2024
@oyvindeide oyvindeide moved this from Backlog to Todo in SCOUT Dec 17, 2024
@oyvindeide
Copy link
Collaborator

This is most likely just used in Everest, and we should just start using the same as ert. Should double check if there are any uses though.

@oyvindeide oyvindeide changed the title Add a log-statement for new_style/SIMULATION_JOB Remove SIMULATION_JOB Dec 17, 2024
@berland
Copy link
Contributor

berland commented Dec 18, 2024

Just to point out the obvious other uses:

ert/test-data/poly_example/poly.ert

Line 18 in 66a8030

SIMULATION_JOB poly_eval

This was changed to FORWARD_MODEL in d347cb4

@DanSava DanSava self-assigned this Dec 18, 2024
@DanSava DanSava moved this from Todo to Ready for Review in SCOUT Dec 18, 2024
@DanSava DanSava moved this from Ready for Review to In Progress in SCOUT Dec 18, 2024
@DanSava DanSava linked a pull request Dec 20, 2024 that will close this issue
Open
9 tasks
@DanSava DanSava moved this from In Progress to Ready for Review in SCOUT Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanSava DanSava

Labels
None yet
Projects
SCOUT
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove SIMULATION_JOB keyword equinor/ert
6 participants
@berland @sondreso @oysteoh @DanSava @eivindjahren @oyvindeide