Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starknet_getEvents filter params is incorrect #536

Closed
Mirko-von-Leipzig opened this issue Aug 26, 2022 · 0 comments · Fixed by #540
Closed

starknet_getEvents filter params is incorrect #536

Mirko-von-Leipzig opened this issue Aug 26, 2022 · 0 comments · Fixed by #540

Comments

@Mirko-von-Leipzig
Copy link
Contributor

Original issue: starkware-libs/starknet-specs#48

We still rename to_block and from_block to camelCase which is incorrect.

Issue also raises that there should be two separate objects for page and range components, but I'm not sure that is correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rpc): use from_block and to_block in event filter eqlabs/pathfinder
1 participant
@Mirko-von-Leipzig