Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified files appearing as recently added #571

Open
simonbun opened this issue Dec 15, 2024 · 5 comments
Open

Modified files appearing as recently added #571

simonbun opened this issue Dec 15, 2024 · 5 comments

Comments

@simonbun
Copy link

I've just modified a single tag on a couple of albums to ensure that, when an artist's discography is presented in chronological order the albums that were released in the same year are correctly ordered (populated with full YYYY-MM-DD in OriginalDate), but after a rescan those albums now appear as Recently Added.

Looking at the database LMS knows they're the same files because of the ids.

The following data is from a subsequent test of a Single.

Before

$ select * from release where name = 'Paint It Black';
id|version|name|sort_name|mbid|group_mbid|total_disc|artist_display_name|is_compilation|image_id|barcode
1949|1|Paint It Black||||1|The Rolling Stones|0|1073|042288214427

$ select id,track_number,name,original_date,file_last_write,file_added from track where release_id = 1949;
id|track_number|name|original_date|file_last_write|file_added
7888|2|Long Long While|1966-05-07|2024-12-14T13:49:06.000|2024-12-15T09:40:45.292
7889|1|Paint It Black|1966-05-07|2024-12-14T13:49:06.000|2024-12-15T09:40:46.765

After

$ select * from release where name = 'Paint It Black';
id|version|name|sort_name|mbid|group_mbid|total_disc|artist_display_name|is_compilation|image_id|barcode
1949|2|Paint It Black||||1|The Rolling Stones|0|1073|042288214427

$ select id,track_number,name,original_date,file_last_write,file_added from track where release_id = 1949;
7888|2|Long Long While|1966-05-07|2024-12-15T13:43:50.000|2024-12-15T13:44:41.622
7889|1|Paint It Black|1966-05-07|2024-12-15T13:43:50.000|2024-12-15T13:44:41.632

It appears LMS is tracking the changes (from the version field, which I forgot to output in the track query), but for an album/track that's already being tracked shouldn't the earliest modification date be used for assessing recently added?

I can't see any open Issues/Discussions or configuration options to control this, but I hope I haven't missed anything?

I'm running LMS 3.61 in Docker.

@epoupon
Copy link
Owner

epoupon commented Dec 15, 2024

Hello!
Actually lms should be able to track both creation and update times. Maybe we want to be able to filter by both criterias? ("recently added" / "recently modified"?)
Edit: for now the "recently added" filter is indeed a "recently modified" filter

@simonbun
Copy link
Author

simonbun commented Dec 15, 2024

Hi!

Actually lms should be able to track both creation and update times.

Do you mean that it could track them in the future? From the track table it doesn't appear to be tracking either at the moment - unless it's being tracked in another table?

Maybe we want to be able to filter by both criterias? ("recently added" / "recently modified"?)

getAlbumList2 appears to support 'newest' and 'recent' (no idea of the difference), but Symfonium only supports recently added, which I think is the standard supported by most servers.

Edit: for now the "recently added" filter is indeed a "recently modified" filter

That's certainly what I'm seeing in LMS and Symfonium.

@epoupon
Copy link
Owner

epoupon commented Dec 15, 2024

Personnaly I find more useful to have recently modified items rather than recently added items. But fine I will add this one if that's what people want!

@simonbun
Copy link
Author

Personnaly I find more useful to have recently modified items rather than recently added items. But fine I will add this one if that's what people want!

Maybe it's a workflow thing. Do you index your music before you've "completed" tagging?

I just did a quick test with 4 servers and 5 albums.

I created 5 albums in order of album name (so creation/modification dates follow album name), loaded the first 4 into the server and looked at the recently added list:

				Minim	Plex	Jelly	Asset
(1) A New Flame			4	2	4	4
(2) Calling All Stations	3	1	3	3
(3) Faith			2	4	2	2
(4) Hard Candy			1	3	1	1

I don't know what order Plex used but the others followed the creation/modification time.

I then:

  • Edited 2
  • Edited 1
  • Added the fifth album (creation and modification dates are later than 3 and 4 but earlier than 1 and 2)
  • Performed a rescan
				Minim	Plex	Jelly	Asset
(1) A New Flame			5	3	5	5
(2) Calling All Stations	4	2	4	4
(3) Faith			3	5	3	3
(4) Hard Candy			2	4	2	2
(5) If You Wait			1	1	1	1

None of the tracked albums changed order.

This testing was carried out on Windows.

Given you prefer modification why not make it configurable, or offer both in the web-gui and a switch for use with clients?

@epoupon
Copy link
Owner

epoupon commented Dec 15, 2024

Thanks for the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants