Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to filter by artist/genre case-insensitive? #529

Open
stkw0 opened this issue Sep 25, 2024 · 6 comments
Open

Option to filter by artist/genre case-insensitive? #529

stkw0 opened this issue Sep 25, 2024 · 6 comments

Comments

@stkw0
Copy link
Contributor

stkw0 commented Sep 25, 2024

I have some albums where the artist name is the same but the string used is different, eg: Go!Go!7188, GO!GO!7188 and GO!GO! 7188. Same with music genres, where some are wrote as "jrock" other "j-rock", "Jrock" and so on.

Would it be feasible to add an option to be insensitive in regard to case and common separators like the space and the - sign?

@epoupon
Copy link
Owner

epoupon commented Sep 25, 2024

But then we would have to chose one representation: the first one hit?

@stkw0
Copy link
Contributor Author

stkw0 commented Sep 25, 2024

Personally I don't care too much about it, but if MusicBrainz is activated, maybe the name used by that service could be used as the canonical name? In either case, it would require, if the metadata of the files are not changed (in my use case for example I can not do that), to make a map between the actual metadata on the files and the internal representation of LMS.

@epoupon
Copy link
Owner

epoupon commented Sep 25, 2024

Yes but you want a unique artist page where you can find the albums of your artist, and we have to put a single name here (Go!Go!7188 or GO!GO!7188?)
Edit: I mean lms does not maintain a list of names for an artist, but it may be somewhat related to #409

@epoupon epoupon closed this as completed Sep 25, 2024
@epoupon epoupon reopened this Sep 25, 2024
@stkw0
Copy link
Contributor Author

stkw0 commented Sep 25, 2024

The first one hit would work and be easier to implement maybe? What I'm currently doing is making playlist for the artists that I want, but is a ugly workaround.

@stkw0
Copy link
Contributor Author

stkw0 commented Sep 25, 2024

Edit: I mean lms does not maintain a list of names for an artist, but it may be somewhat related to #409

Yes, I think my issue is an easier subset of that one. In my case the names are exactly the same, but with different case, not a group with two different names.

@epoupon
Copy link
Owner

epoupon commented Sep 25, 2024

Ah, and also for now, lms does use the mbid of the artists to match them. If the spelling is different for the same mbid, the last one scanned wins.
But if a track does not have an artist mbid, then lms does not try to match artists that have one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants