Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS API returns only year for incomplete original release dates #477

Open
splintering opened this issue May 29, 2024 · 1 comment
Open

OS API returns only year for incomplete original release dates #477

splintering opened this issue May 29, 2024 · 1 comment

Comments

@splintering
Copy link

The field "originalReleaseDate" in the AlbumID3 set of the OS API contains an array with "year", "month" and "day" entries.

If the coresponding tag does not contain a full calendar date (YYYY-MM-DD), but a partial date (e.g. YYYY-MM), or an invalid date (e.g. YYYY-MM-00), then LMS will only return the year. I would expect that at least in the case of YYYY-MM, year and month are returned. As a courtesy, the same could be done for YYYY-MM-00, as the 00 indicates that no specific day of the month is meant.

Examples of what is currently being sent:
Date in tag -> sent by LMS via OS API
1955-02-01 -> "originalReleaseDate":{"day":1,"month":2,"year":1955}
1955-02-00 -> "originalReleaseDate":{"year":1955}
1955-02 -> "originalReleaseDate":{"year":1955}
I think the latter two cases should sent "originalReleaseDate":{"month":2,"year":1955}

@epoupon
Copy link
Owner

epoupon commented May 29, 2024

Hello!
Indeed, LMS stores a year and possibly a full date (year+month+day), this requires some changes in the parser and the database schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants