Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Multisearch #461

Open
michalmoc opened this issue May 9, 2024 · 1 comment
Open

[Feature request] Multisearch #461

michalmoc opened this issue May 9, 2024 · 1 comment

Comments

@michalmoc
Copy link
Contributor

michalmoc commented May 9, 2024

It's not rare that after typing my query I find out I'm on wrong tab and therefore I won't find what I search for. I need to switch tab and type the query again. The same way, when I'm listening to an album, if I want to search for something I need an additional click to switch to proper tab.

I believe it would be far more convenient to have a single searcher at the tab bar, which would search through all resources. It seems to be already widely accepted solution: Spotify does exactly that, Google (while maintaining separate searchers) in web search suggests also some images and other resources.

Spotify splits results in separate categories, but in my opinion it would be better to have single list sorted by relevance.

Current status

Seems finished, waiting for @epoupon review.

Known problems

  • new interface settings need manual browser refresh - no idea how to fix it
  • SQLite bundled with WT lacks support for JSON, it needs to be compiled with -DUSE_SYSTEM_SQLITE3=ON
  • search is case-sensitive for unicode characters - present in original searchers too, probably unsolvable with SQLite
@epoupon
Copy link
Owner

epoupon commented May 9, 2024

Hello!
I removed the "global" search field/view because it feels a bit redundant with the individual 'search' items in albums/artists/tracks.
Edit: you had to first enter the keywords and then select the searched field (artist/tracks/albums, with albums displayed by default, that was not really straightforward.
Furthermore, showing multiple search fields on the same page looked really confusing.
But yes I do agree with you, a single search in all resources is actually quite handy.

This was referenced May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants