Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken/missing lesson navigation #202

Closed
denkasyanov opened this issue Mar 26, 2024 · 11 comments
Closed

Broken/missing lesson navigation #202

denkasyanov opened this issue Mar 26, 2024 · 11 comments

Comments

@denkasyanov
Copy link

During previous couple updates I noticed that sidebar navigation is sometimes broken and sometimes parts of it are missing.

Below is an example of missing links.

I'll add more screenshots with different kind of issues when I encounter it.

CleanShot 2024-03-26 at 22 56 22@2x

Steps before this issue:

  1. I updated kcdshop with npx update-epic-workshop
  2. Started it with npm start.
  3. Watched a video in the previous lesson in full screen, marked two exercises as complete. Skipped google forms because captcha is unbearable (but I digress).
  4. Pressed ">" button to open the next lesson.

Refreshing the page fixes it until next time

@kentcdodds
Copy link
Member

Thanks for reporting! This is very odd. I cannot reproduce the issue. Could you do a little debugging for me? Check the console for errors and check the DOM over there for odd CSS rules being applied or something?

@denkasyanov
Copy link
Author

denkasyanov commented Mar 26, 2024

Both Chrome console and server console show no errors.

CleanShot 2024-03-27 at 03 08 02@2x

I had to removed two opacity style properties to show it again, on ul and li.
opacity: 0 returns after some time or after I switch to another tab and return back.

CleanShot 2024-03-27 at 03 11 44@2x

Probably I shared what I found in a very dumb way. Please let me know if there is a better way to do it 😅

I also disabled uBlock Origin before that (no difference).

@denkasyanov
Copy link
Author

denkasyanov commented Mar 27, 2024

Aand another one
CleanShot 2024-03-27 at 07 37 41@2x

Steps:

  1. I returned to the page
  2. Rewatched the end of the video
  3. Clicked on top left menu to open sidebar
  4. One bar disappared from the open menu button
  5. The sidebar doesn't open no matter how many times I click this button

This time there are errors in the chrome console

@kentcdodds
Copy link
Member

Could you try disabling the Google translate extension?

@denkasyanov
Copy link
Author

Completed the first lesson in the next workshop with Google translate extension disabled.
And the first issue appeared again right after I moved to the next lesson.
CleanShot 2024-03-28 at 03 26 23@2x

I guess I'm ok with refreshing the page.

@kentcdodds
Copy link
Member

Dang. This is so weird. I've not had reports from anyone else so I'm thinking it's probably something wrong with an extension you've got or something. Sorry!

@denkasyanov
Copy link
Author

After some additional testing, I believe the offending extension is 1Password https://chromewebstore.google.com/detail/1password-%E2%80%93-password-mana/aeblfdkhhhdcdjpifhhbdiojplfjncoa

I completed a couple of lessons without 1Password extension in freshly installed Brave browser. Didn't use this browser before. No issues with the sidebar.

Tried different combinations of my usual extensions and very soon after I enable 1Password (with or with no other extensions) the issues appear in Brave as well.

I don't know the exact order of steps to reliably reproduce it.

However, this time, right after I installed it in Brave (and it connected to 1Passowrd desktop app) and tried to close the sidebar, this happened
CleanShot 2024-03-31 at 02 02 40@2x

Something like this happened in Chrome as well.

@denkasyanov
Copy link
Author

denkasyanov commented Mar 30, 2024

Actually, it happens even without extensions.

I'm in the DATA MODELING DEEP DIVE workshop.

First scenario, in which everything works fine.

  • I'm on page "Updating Data" (http://localhost:5639/07)
  • Click on "SQL" section in the sidebar
  • SQL section reveals with all lessons visible

Second scenario

  • I'm on page "Updating Data" (http://localhost:5639/07)
  • Click "Elaboration" lesson in this section (http://localhost:5639/07/finished)
  • The lesson is completed
  • Click two times (complete -> uncomplete -> complete)
  • See the confetti animation
  • Click the right arrow button to go to the next lesson (1)
  • Boom, items in the menu are invisible (2)

(1)
CleanShot 2024-03-31 at 02 46 20@2x

(2)
CleanShot 2024-03-31 at 02 48 59@2x

Notes:

  • If I click only one time to uncomplete elaboration (no confetti) menu works fine
  • Above scenarios were tested in Brave browser. No extensions at all, even disabled.
  • Exactly the same thing is happening in Safari
  • Looks like confetti in any other lessons leads to the same issue with menu. Also, when navigating via sidebar menu, not necessarily using the button under the complete lesson checkbox. Reproduced both in pristine Brave and regular Safari.
  • The same issue with confetti on windows 11 in Chrome and Edge

@kentcdodds
Copy link
Member

Ah! I reproduced it using the steps you provided! Phew! Thank you for coming up with these steps.

I see some relevant errors in the console:

animation-related errors

This is helpful. Thank you!

@d3vl1m3
Copy link

d3vl1m3 commented Apr 4, 2024

Perfect. Yeah. I found the same issue recently as well. Great to see it's already been highlighted :)

Screen capture of issue if it's of any help. Issue is absolutely when marking something as complete and navigating to another menu item:

Screencast.from.03-04-24.15.33.16.webm

@kentcdodds
Copy link
Member

I think this has been fixed. Anyone care to verify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants