Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open sidebar menu over the content #100

Open
onemen opened this issue Jul 17, 2023 · 5 comments
Open

open sidebar menu over the content #100

onemen opened this issue Jul 17, 2023 · 5 comments

Comments

@onemen
Copy link
Contributor

onemen commented Jul 17, 2023

@kentcdodds
what do you think about this?

menu-sidebar

@kentcdodds
Copy link
Member

kentcdodds commented Jul 17, 2023

I have mixed feelings about this. Part of me feels that people may use the left nav to help them find something and if it covers the content they may not be able to quickly find what they're looking for. I think let's leave it as it is currently until someone complains.

@onemen
Copy link
Contributor Author

onemen commented Jul 19, 2023

menu-overlay

we can add button/checkbox to let users toggle the menu behavior

@kentcdodds
Copy link
Member

I'm open for doing that 👍 I'd want to use shadcn's checkbox so it looks nice :)

@onemen
Copy link
Contributor Author

onemen commented Jul 19, 2023

Do you want the checkbox to be visible when the menu is closed, with a tool-tip
Does the label ok? just 'Overlay Menu' or 'Overlay Menu ON' 'Overlay Menu OFF'

do i save user preference as a cookie or in local-storage?

maybe we can use suitable icon / emoji instead of a checkbox? can you propose one?

@kentcdodds
Copy link
Member

Yeah, I think an icon would be better for this as well.

Local storage is a fine place for this.

The more I think about it though, the more I think it's not necessary. Let's hold off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants