Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve max payment validation #39

Open
3 tasks
str opened this issue Apr 11, 2020 · 0 comments
Open
3 tasks

Improve max payment validation #39

str opened this issue Apr 11, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@str
Copy link
Member

str commented Apr 11, 2020

The max-payment field has a validation not to accept amounts above a "max" filter. But if the payment is set, and then the max-paymnet is lowered, the payment requested will be above the new "max" value. We need to improve validation in that case.

I tried different methods according to the quasar-input validation, but it looks like it's going to need more time invested to fix it. But validation needs to happen also on the chain side,

  • if editing, and having the value pre-set above max (because max was updated), show an error and do not allow to submit until setting below max (see https://quasar.dev/vue-components/input#Validation)
  • What should happen if claiming a payment above max-payment?
  • Candidates can be reelected if having a payment request above max-payment?
@str str added the enhancement New feature or request label Apr 12, 2020
@str str added this to the dacfactory-v1.0 milestone Apr 12, 2020
@str str modified the milestones: dacfactory-v1.0, dacfactory-v1.1 Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant