You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think we can just cancel the previous watch and not create another one in this case. Please let me know if this makes sense, and I’ll be happy to submit a PR.
The text was updated successfully, but these errors were encountered:
According to the Envoy xDS protocol documentation:
However, the
DiscoveryRequestStreamObserver
currently creates a new watch even when the resource names list becomes empty, which violates the spec.https://github.com/envoyproxy/java-control-plane/blob/main/server/src/main/java/io/envoyproxy/controlplane/server/DiscoveryRequestStreamObserver.java#L80-L94
I think we can just cancel the previous watch and not create another one in this case. Please let me know if this makes sense, and I’ll be happy to submit a PR.
The text was updated successfully, but these errors were encountered: