Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch Created with Empty Resource Names #411

Open
minwoox opened this issue Sep 23, 2024 · 0 comments
Open

Watch Created with Empty Resource Names #411

minwoox opened this issue Sep 23, 2024 · 0 comments

Comments

@minwoox
Copy link
Contributor

minwoox commented Sep 23, 2024

According to the Envoy xDS protocol documentation:

If the list of resource names becomes empty, that means the client is no longer interested in any resources of the specified type.

However, the DiscoveryRequestStreamObserver currently creates a new watch even when the resource names list becomes empty, which violates the spec.
https://github.com/envoyproxy/java-control-plane/blob/main/server/src/main/java/io/envoyproxy/controlplane/server/DiscoveryRequestStreamObserver.java#L80-L94

I think we can just cancel the previous watch and not create another one in this case. Please let me know if this makes sense, and I’ll be happy to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant