Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support additional timings in COMMON_DURATION #37063

Open
guydc opened this issue Nov 8, 2024 · 0 comments
Open

Support additional timings in COMMON_DURATION #37063

guydc opened this issue Nov 8, 2024 · 0 comments
Labels
enhancement Feature requests. Not bugs or questions. triage Issue requires triage

Comments

@guydc
Copy link

guydc commented Nov 8, 2024

Description:
Envoy currently records several upstream connection time points that are not supported by the %COMMON_DURATION(...)% operator:

absl::optional<MonotonicTime> upstream_connect_start_;
absl::optional<MonotonicTime> upstream_connect_complete_;
absl::optional<MonotonicTime> upstream_handshake_complete_;

These timestamps are useful for identifying the overhead of upstream TCP/TLS connection establishment. The %UPSTREAM_CONNECTION_POOL_READY_DURATION% operator provides the total connection establishment time, but it does not distinguish between the TCP and TLS parts and is only available in millisecond resolution. The above-mentioned time points can be supported in the %COMMON_DURATION(...)% operator to achieve that.

@guydc guydc added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests. Not bugs or questions. triage Issue requires triage
Projects
None yet
Development

No branches or pull requests

1 participant