Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra search query param on the editor tab breaks the whole editor #11923

Open
MrFlashAccount opened this issue Dec 19, 2024 · 1 comment · May be fixed by #11960
Open

Extra search query param on the editor tab breaks the whole editor #11923

MrFlashAccount opened this issue Dec 19, 2024 · 1 comment · May be fixed by #11960
Assignees
Labels
--bug Type: bug -gui p-high Should be completed in the next sprint

Comments

@MrFlashAccount
Copy link
Contributor

Recently we got a bug request from a User, with broken Project view because it failed to recognize the search param 'starModalDefaultOpen`

Proposing to make the Project view less strict on extra search params in the URL.

User's issue: #11912

Related discussion: https://discord.com/channels/401396655599124480/1201853512409939968/1226854319983300728

@MrFlashAccount MrFlashAccount added p-high Should be completed in the next sprint --bug Type: bug -gui labels Dec 19, 2024
@MrFlashAccount MrFlashAccount self-assigned this Dec 19, 2024
@farmaazon
Copy link
Contributor

The fix is already part of my work on #11185

There we don't break on unknown argument, just print warning ATM (but perhaps I'll resign even from a warning).

@farmaazon farmaazon assigned farmaazon and unassigned AdRiley Jan 2, 2025
@farmaazon farmaazon added this to the 2024-End-Of-Year milestone Jan 2, 2025
@farmaazon farmaazon moved this from ❓New to 🔧 Implementation in Issues Board Jan 2, 2025
@farmaazon farmaazon linked a pull request Jan 3, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui p-high Should be completed in the next sprint
Projects
Status: 🔧 Implementation
Development

Successfully merging a pull request may close this issue.

3 participants