Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite rest of global typing pass group to mini passes #11703

Open
Akirathan opened this issue Nov 28, 2024 · 2 comments · May be fixed by #11717
Open

Rewrite rest of global typing pass group to mini passes #11703

Akirathan opened this issue Nov 28, 2024 · 2 comments · May be fixed by #11717
Assignees
@Akirathan
Labels
-compiler

Comments

@Akirathan
Copy link
Member

Akirathan commented Nov 28, 2024 •
edited
Loading

Follow-up of #11326 (Associated PR in #11501). In global typing pass group:

enso/engine/runtime-compiler/src/main/scala/org/enso/compiler/Passes.scala

Lines 41 to 63 in 4e6837f

val globalTypingPasses = new PassGroup(
List(
MethodDefinitions.INSTANCE,
SectionsToBinOp.INSTANCE,
OperatorToFunction,
LambdaShorthandToLambda,
ImportSymbolAnalysis.INSTANCE,
AmbiguousImportsAnalysis.INSTANCE
) ++ (if (config.privateCheckEnabled) {
List(
PrivateModuleAnalysis.INSTANCE,
PrivateConstructorAnalysis.INSTANCE
)
} else List())
++ List(
ShadowedPatternFields,
UnreachableMatchBranches,
NestedPatternMatch,
IgnoredBindings,
TypeFunctions,
TypeSignatures
)
)

Passes MethodDefinitions, up to PrivateConstructorAnalysis were migrated to mini passes. Let's migrate the rest of them (or at least 3 of them):

  • ShadowedPatternFields
  • UnreachableMatchBranches
  • NestedPatternMatch
  • IgnoredBindings
  • TypeFunctions
  • TypeSignatures

Note that it is advantageous to migrate mega passes that run immediately before/after mini passes, so that as many mini passes are chained as possible.

Before the migration, let's first integrate a PR that just converts these mega passes to Java.
@Akirathan Akirathan self-assigned this Nov 28, 2024
@Akirathan Akirathan linked a pull request Nov 29, 2024 that will close this issue
Draft
5 tasks
@enso-bot
Copy link

enso-bot bot commented Nov 29, 2024

Pavel Marek reports a new STANDUP for today (2024-11-29):

Progress: - Migrated ShadowedPatternFields and UnreachableMatchBranches

  • First convert to mini, run tests, and then convert to Java.
    • This is easier than to do these two steps at once. It should be finished by 2024-12-04.

@enso-bot
Copy link

enso-bot bot commented Dec 2, 2024

Pavel Marek reports a new STANDUP for today (2024-12-02):

Progress: - Refactor UnreachableMatchBranches to Java.

  • Figuring out a proper GH Copilot prompt to help us with the refactoring. So far, still a lot of manual rewrite is necessary. It should be finished by 2024-12-04.

@JaroslavTulach JaroslavTulach moved this from ❓New to 🔧 Implementation in Issues Board Dec 3, 2024
@JaroslavTulach JaroslavTulach moved this from 🔧 Implementation to ⚙️ Design in Issues Board Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Akirathan Akirathan

Labels
-compiler
Projects
Issues Board
Status: ⚙️ Design
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert rest of global typing pass group to mini passes enso-org/enso
1 participant
@Akirathan