You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
diff --git a/test/Table_Tests/src/IO/Excel_Spec.enso b/test/Table_Tests/src/IO/Excel_Spec.enso--- a/test/Table_Tests/src/IO/Excel_Spec.enso (revision 28c59ca66474346052d4bdf4283382feb04cb3cb)+++ b/test/Table_Tests/src/IO/Excel_Spec.enso (date 1731067786353)@@ -644,9 +644,11 @@
f = parent / ("foo."+suffix)
t1 = Table.new [["X", [1, 2, 3]]]
r1 = t1.write f (..Sheet "Another")
- Test.with_clue "("+r1.catch.to_display_text+") " <|+ Test.with_clue "(r1 = "+r1.catch.to_display_text+") " <|
r1.should_fail_with File_Error
r1.catch.should_be_a File_Error.Not_Found
+ # We want the Not found error to point to the nonexistent directory, not some file that is just being written.+ r1.catch.file.path . should_equal parent.path
group_builder.specify "should allow to write and read-back Unicode characters" <|
encodings = enso_project.data / "transient" / ("encodings."+suffix)
Currently it fails with:
- [FAILED] should fail if the parent directory does not exist [7ms]
Reason: (The file at X:\NBO\enso\test\Table_Tests\data\transient\nonexistent\foo.xls.temp.262091447510400 does not exist.) 'X:\\NBO\\enso\\test\\Table_Tests\\data\\transient\\nonexistent\\foo.xls.temp.262091447510400' did not equal 'X:\\NBO\\enso\\test\\Table_Tests\\data\\transient\\nonexistent' (at X:\NBO\enso\test\Table_Tests\src\IO\Excel_Spec.enso:651:17-61).
The problem is that the Not_Found error is associated with a path to a temporary file created next to the destination. It is misleading. It says that some random temp file does not exist. Which is confusing for the user because why some random file not existing be a problem??
The true error is the parent directory not existing and the reported error should reflect that.
Bonus points: ideally, if we create an XLS under foo/nonexistent_directory/child_dir/f.xls, it should also correctly report the directory and the file. Here it seems ok to return either Not_Found foo/nonexistent_directory/ or Not_Found foo/nonexistent_directory/child_dir, as both directories do not exist.
The text was updated successfully, but these errors were encountered:
The following test should pass:
Currently it fails with:
The problem is that the
Not_Found
error is associated with a path to a temporary file created next to the destination. It is misleading. It says that some random temp file does not exist. Which is confusing for the user because why some random file not existing be a problem??The true error is the parent directory not existing and the reported error should reflect that.
Bonus points: ideally, if we create an XLS under
foo/nonexistent_directory/child_dir/f.xls
, it should also correctly report the directory and the file. Here it seems ok to return eitherNot_Found foo/nonexistent_directory/
orNot_Found foo/nonexistent_directory/child_dir
, as both directories do not exist.The text was updated successfully, but these errors were encountered: