Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bazel in place of pnpm calls in rust build script. #10508

Closed
Tracked by #10145
farmaazon opened this issue Jul 10, 2024 · 64 comments
Closed
Tracked by #10145

Use bazel in place of pnpm calls in rust build script. #10508

farmaazon opened this issue Jul 10, 2024 · 64 comments
Assignees
Labels
-build-script Category: build script -gui

Comments

@farmaazon
Copy link
Contributor

No description provided.

@farmaazon farmaazon added d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints -build-script Category: build script -gui labels Jul 10, 2024
@farmaazon farmaazon added this to the 2024-08 Release milestone Jul 10, 2024
@farmaazon farmaazon moved this from ❓New to 📤 Backlog in Issues Board Jul 11, 2024
@farmaazon
Copy link
Contributor Author

  • The initial implementation of Bazel maybe a reference point (but the package structure is much outdated). (wip/frizi/bazel branch). And it does not have working wasm parser dependency.

@Frizi Frizi moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jul 19, 2024
@enso-bot
Copy link

enso-bot bot commented Aug 15, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-07-19):

Progress: Merged bazel branch with latest develop in preparation for rust-specific build pipeline work. It should be finished by 2024-08-19.

@enso-bot
Copy link

enso-bot bot commented Aug 15, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-07-24):

Progress: Getting familiar with bazel rust-rules module, atempted to use rust-rules for building parser. So far build fails because of hitting MAX_PATH in build directories created by bazel. It should be finished by 2024-08-19.

@enso-bot
Copy link

enso-bot bot commented Aug 15, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-07-26):

Progress: Created a separate toy repository to attempt creating a rust bazel setup in simpler environment. Still hitting the same MAX_PATH issues. I now understand that it a rule-internal build that fails, not our own configuration. Wasn't yet successful in finding a way around the issue. It should be finished by 2024-08-19.

@enso-bot
Copy link

enso-bot bot commented Sep 2, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-08-28):

Progress: Continuing investation of wasm_bindgen max_path issues. It should be finished by 2024-09-09.

@enso-bot
Copy link

enso-bot bot commented Sep 2, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-08-29):

Progress: Continuing investation of wasm_bindgen max_path issues. It should be finished by 2024-09-09.

@enso-bot
Copy link

enso-bot bot commented Sep 2, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-08-30):

Progress: Identified the source of max_path issues to be related to a nested c++ build script within a wasm_bindgen's dependency crate's build.rs script. Managed to finally fix the issue in a low-complexity repository by declaring custom toolchain and separate crate universe for local version of wasm-bindgen-cli. It should be finished by 2024-09-09.

@enso-bot
Copy link

enso-bot bot commented Sep 2, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-08-27):

Progress: Configured wasm_bindgen build targets, but now getting another windows-specific max_path issues when attemtping to build through wasm-bindgen. It should be finished by 2024-09-09.

@enso-bot
Copy link

enso-bot bot commented Sep 2, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-08-26):

Progress: Attempting to use rules_rust wasm_bindgen rules to build rust-ffi crate as a wasm package. It should be finished by 2024-09-09.

@enso-bot
Copy link

enso-bot bot commented Sep 2, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-08-06):

Progress: Fighting with max_path issues during rust crate compilation. It should be finished by 2024-09-09.

@enso-bot
Copy link

enso-bot bot commented Sep 2, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-08-07):

Progress: Investigating max_path issues by modifying local copy of rules_rust, trying to shorten the generated file paths. It should be finished by 2024-09-09.

@enso-bot
Copy link

enso-bot bot commented Sep 2, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-08-08):

Progress: Created a rules_rust patch to shorten the internal name of rust msvc toolchain. Successfuly built rust-ffi as a native rust library through bazel. It should be finished by 2024-09-09.

@Frizi Frizi added the x-on-hold label Sep 4, 2024
@enso-bot
Copy link

enso-bot bot commented Sep 5, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-09-02):

Progress: Ported wasm-bindgen toolchain settings to bazel branch of enso repository, experimented with using prebuilt binaries. It should be finished by 2024-09-09.

@enso-bot
Copy link

enso-bot bot commented Sep 5, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-09-03):

Progress: Now able to generate wasm package through bazel. Task is now temporarily put on hold to focus on next release. It should be finished by 2024-09-09.

@enso-bot
Copy link

enso-bot bot commented Nov 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-10-21):

Progress: Working on support for environment and dotenv files in bazel build. It should be finished by 2024-11-10.

@enso-bot
Copy link

enso-bot bot commented Nov 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-10-22):

Progress: Working on support for environment and dotenv files in bazel build. It should be finished by 2024-11-10.

@enso-bot
Copy link

enso-bot bot commented Nov 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-10-23):

Progress: Merged with latest develop and cleaning up type-check and linting issues. It should be finished by 2024-11-10.

@enso-bot
Copy link

enso-bot bot commented Nov 19, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-10-28):

Progress: Addressed review, resolving CI issues on windows runners. It should be finished by 2024-11-10.

@enso-bot
Copy link

enso-bot bot commented Dec 16, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-12-13):

Progress: Investigating issues with tsc picking up leftover typescript files from previous builds. It should be finished by 2024-12-22.

@enso-bot
Copy link

enso-bot bot commented Dec 18, 2024

Paweł Grabarz reports a new STANDUP for the provided date (2024-12-16):

Progress: Understood issues with non-hermetic vite build, but after many attempts decided to not focus on fixing it. It will eventually be resolved upstream. It should be finished by 2024-12-22.

@enso-bot
Copy link

enso-bot bot commented Dec 18, 2024

Paweł Grabarz reports a new STANDUP for yesterday (2024-12-17):

Progress: Cleaning up broken things after last huge merge. It should be finished by 2024-12-22.

@enso-bot
Copy link

enso-bot bot commented Dec 19, 2024

Paweł Grabarz reports a new STANDUP for yesterday (2024-12-18):

Progress: Working through gui bazel build issues related to config env replacement. It should be finished by 2024-12-22.

@enso-bot
Copy link

enso-bot bot commented Dec 20, 2024

Ilya Bogdanov reports a new STANDUP for yesterday (2024-12-19):

Progress: Pair programming on bazel It should be finished by 2024-12-22.

@enso-bot
Copy link

enso-bot bot commented Dec 23, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-12-20):

Progress: Pair programming on bazel It should be finished by 2024-12-22.

@enso-bot
Copy link

enso-bot bot commented Jan 3, 2025

Paweł Grabarz reports a new STANDUP for the provided date (2025-01-01):

Progress: Trying to fix bazel's MSVC resolution on windows CI runner. It should be finished by 2025-01-03.

@enso-bot
Copy link

enso-bot bot commented Jan 3, 2025

Paweł Grabarz reports a new STANDUP for yesterday (2025-01-02):

Progress: Unsuccessful attempts to run windows CI runner image locally. Will need SSH access to actual runners to make progress, switching tasks for now. It should be finished by 2025-01-03.

@enso-bot
Copy link

enso-bot bot commented Jan 3, 2025

Paweł Grabarz reports a new STANDUP for the provided date (2024-12-31):

Progress: Updating rules_rust in hopes of resolving windows issue, attemtping to use BAZEL_VC environment setting for msvc resolution with no success so far. It should be finished by 2025-01-03.

@Frizi Frizi moved this from 🔧 Implementation to 👁️ Code review in Issues Board Jan 9, 2025
@enso-bot
Copy link

enso-bot bot commented Jan 9, 2025

Ilya Bogdanov reports a new STANDUP for today (2025-01-09):

Progress: Pair programming on bazel It should be finished by 2025-01-09.

@enso-bot
Copy link

enso-bot bot commented Jan 9, 2025

Paweł Grabarz reports a new STANDUP for yesterday (2025-01-08):

Progress: Debugging Windows CI machines through SSH. Finally understood the environment configuration problem, caused by ENV variables declared through CMD shell having trailing whitespaces. It should be finished by 2025-01-09.

@enso-bot
Copy link

enso-bot bot commented Jan 10, 2025

Paweł Grabarz reports a new STANDUP for yesterday (2025-01-09):

Progress: Fixed all remaining windows CI build issues, now keeping the branch up to date with develop with intention to merge as soon as CI issues from develop are resolved. It should be finished by 2025-01-09.

@enso-bot
Copy link

enso-bot bot commented Jan 13, 2025

Ilya Bogdanov reports a new STANDUP for the provided date (2025-01-10):

Progress: Merging the latest develop, there is a linter failure on CI and locally. Investigating it, didn’t find any difference between files, linter particularly dislikes a specific one. Everything else seems to be working fine. There are also engine failures. It should be finished by 2025-01-10.

@enso-bot
Copy link

enso-bot bot commented Jan 13, 2025

Ilya Bogdanov reports a new STANDUP for the provided date (2025-01-08):

Progress: Pair programming on bazel. It should be finished by 2025-01-10.

@enso-bot
Copy link

enso-bot bot commented Jan 14, 2025

Paweł Grabarz reports a new STANDUP for yesterday (2025-01-13):

Progress: Fixing lint and type issues after develop merges, trying to get the PR to merge. It should be finished by 2025-01-14.

@enso-bot
Copy link

enso-bot bot commented Jan 15, 2025

Paweł Grabarz reports a new STANDUP for yesterday (2025-01-14):

Progress: Did final develop merge resolution and necessary cleanup afterwards, PR finally merged. It should be finished by 2025-01-14.

@farmaazon farmaazon removed d-intermediate Difficulty: some prior knowledge required p-medium Should be completed in the next few sprints labels Jan 16, 2025
@Frizi Frizi moved this from 👁️ Code review to 🟢 Accepted in Issues Board Jan 16, 2025
@vitvakatu
Copy link
Contributor

I guess we can close it as completed in #11337

@farmaazon farmaazon moved this from 🟢 Accepted to 🗄️ Archived in Issues Board Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-build-script Category: build script -gui
Projects
Status: 🗄️ Archived
Development

No branches or pull requests

4 participants