[2023-02-13] Performance Team Demo

[wdanilo]

Let me start! :)

I was working on improving the Electron integration, this involves:

• Unifying how we pass flags between Electron, Rust, and the code running in the browser.
• Updating Electron to the newest version.
• Reviewing possible Electron/Chrome flags to make it more performant and working better on different systems.
• The whole electron management code was rewritten from JS to TS. It was ugly because it was first a test and it survived till now. Now it's properly written and documented.

The PR is opened, still not all code cleaned, will be cleaned for tomorrow: #5633

As a result, we've got Electron app working on M2 Macs (not crashing anymore, I hope). Also, it should remove some of community issues, including this one: #3801

As a side improvement, the command line interface is way nicer now, here is the screenshot of running the electron app with -help command (not all switches are visible, as we have almost a 100 switches now, including chrome/electron switches to debug the app).

[JaroslavTulach]

Based on the Feb 6 Demo review feedback individual issues were reported and are being worked on:

• Pre-compute Suggestion DB during build time #5068 (Dmitry, Jaroslav)
• Process only Requested Modules when Resolving Imports #5568 (Hubert)
  • Investigate More Effective IR Caching format #5567 (Hubert)

Low priority tasks reported:

• Automating Startup Measurement #5569
• Investigate transfer of Suggestion DB to IDE as binary not as JSON #5570

Custom Hashing has been fully integrated :

• speeds Vector.distinct up
• supports custom hashcode and equals implementations
• consistency guaranteed
• support for inequality operators (e.g. <, <=, >, >=)
• no more incompatible API changes planned

We can move forward and bugfix and speed up.

[kazcw]

Last week, the frontend parser transition landed (#4113).

This is what startup looked like before (opening "Orders", zoomed to the part after we receive project source code from the LS):

The circled portion is over 500ms of CPU work in parse_with_metadata; that has been eliminated. The new parse_with_metadata takes 1.8ms.

Since then I've been working on optimizing shader compilation scheduling (#5606). I'll finish that today. Next I'll profile some objectives #5603 and look for the next optimization.

[farmaazon]

Spent much time on taming Github Projects removing all artifacts and improving the rendering of the shapes rendered from the texture. Tested on the real icon from Component Browser - that showed a few new things. Now, I finally made the cached icon (up) looking almost exactly as rendered from traditional shape system (bottom) if they are aligned to the pixels:

Still, things are getting worse when they are not:

Tried to fix that, but this is extremely not easy. However, after a talk with @wdanilo we decided, that the normal shapes, if not aligned to pixels, are bad anyway, and we rather aim to snap things to pixels if they are not moving.

[mwu-tow]

• Reworked watch command to use Electron exutable directly. Reworked ide watch and ide start commands #5634
• • New „ide watch”;
• • New „ide start”.
• Related refactorings.
• Debugging CI issues:
• • Issues with Engine builds — fixed by Hubert. Fix separate compilation for ConstantsGen #5630
• Plans:
• • Finishing PR. Reworked ide watch and ide start commands #5634
• • Reviewing and testing Wojciech's Fixing Electron runner #5633

[Frizi]

Refined argument placeholders and widget support for more complicated expression types.

Added support for widgets in infix expressions (right now only used for file paths)

Widgets and placeholders are handled for all chained methods within a node

The qualified method call convention and static methods no longer confuse the argument placeholders

Type constructor expressions now receive placeholder arguments. The placeholders work on nested expressions within a node.