-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforcing black
for python code formatting
#44
Comments
I'm hesitant with black formatting. I know it's the standard, but there are so many formatting rules that I don't agree with. I've reviewed your PR, and you've managed to make it look VERY good overall. There's a handful of things that the black formatter seems to have gone "too far" with; however, if we're able to get those pieces under control, I think it'll be worth updating. If we're unable to get those pieces, I think it'll be enough to stick with |
|
I've sat on this and been slow; which reflects poorly on me as a maintainer. I want to say though, I've come around to agree with you completely. Not only should we make this repo Black compliant. I think we NEED to have Black compliance in the repo. I'm definitely onboard! :) Thank you for your persistence, and your patience! 😄 |
Removing milestone association since this isn't ready to "roll" yet. |
021cfe7 Sir as our code base is growing in size i want a uniform python code format across all our modules please review it and give your valuable feed bak
The text was updated successfully, but these errors were encountered: