Fix schema validation #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 this looks good to me @BBB! |
BBB
force-pushed
the
bugfix/validation
branch
from
b86d6bf to
ecda102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the schema validation was not working in the example app, so I decided to investigate.
I found that the validator was not able to find the schemas on
endpoint.schema, but that the schema was available onendpoint.config.schema. https://github.com/endpoints/endpoints/blob/69b359b/src/validate-json-schema/index.js#L13I also found that the schemas in the integration test app did not match valid JSON API schemas.
This PR fixes both of these issues and adds an integration test to catch this error. As previously these issues were undiscovered as they were unit tested in isolation.
@tkellen Does this look correct to you? If this is all ok, I'll update the example app too (this would close endpoints/endpoints-example#6 I believe).