Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version numbers don't match #69

Open
cassidyjames opened this issue Sep 18, 2023 · 4 comments
Open

Version numbers don't match #69

cassidyjames opened this issue Sep 18, 2023 · 4 comments

Comments

@cassidyjames
Copy link
Member

cassidyjames commented Sep 18, 2023

We have three places version numbers are shown:

  • 0.3 Flathub app listing/App Center (from AppStream MetaInfo)
  • 0.16.0b5 (0.1) GTK About window (Kolibri version from Meson?)
  • Manatee v6.47.0 In-page About page

Can we plan to align these? Otherwise it's going to be hard to know what version someone is actually using.

@dylanmccall
Copy link
Contributor

dylanmccall commented Sep 19, 2023

Oh dammit, I just realized our last few releases didn't actually increment the version in meson.build. We really need to add a pre-commit check for that.

I think it's safe for us to use the Explore plugin version instead of the Kolibri version in the About window. It's formatted the way it is in the Kolibri app because we want to center that, but in this case it's an implementation detail and we don't need to include it. I do think it's useful to have the app version as its own thing because it isn't necessarily in sync with the Explore plugin version, but indeed, the Explore plugin version is usually the more important one. So, something like Manatee v6.47.0 (0.3) would probably be good :)

And perhaps we can stick all those versions of things in a bit more detail in the debug_info property.

@starnight
Copy link
Contributor

Oh dammit, I just realized our last few releases didn't actually increment the version in meson.build. We really need to add a pre-commit check for that.

Oops! Sorry, I forgot the one in meson.build. My fault.

And, back to the version number of endless-key-flatpak:

  • Current version is temporary. Because, it had not included kolibri-explore-plugin before Enable kolibri-explore-plugin #26, but it has/merged now. :)
  • kolibri-explore-plugin's version string has 3 numbers. But, only uses first two numbers (major & minor) actually.
  • After the welcome-screen is merged, I think it is good to sync the version with kolibri-explore-plugin. For examples from:
    • Windows: the first two numbers are the same of kolibri-explore-plugin's version. The 3rd number is build number. Windows APPX/MISX defines 4th number as 0. ex. 6.47.1.0
    • Chrome OS: the first two numbers are the same of kolibri-explore-plugin's version. The 3rd number is incremented build number. ex. Manatee 6.47-402.

So, I suggest using the same scheme as Windows and Chrome OS: Sync the version's first two numbers of kolibri-explore-plugin. And, the 3rd number is the build number.

dylanmccall added a commit that referenced this issue Sep 20, 2023
This is a quick and dirty solution to maintain a single source of truth
for the project version number. It means that builds will fail when run
outside of a git checkout, but for our current needs, that should be
fine.

#69
dylanmccall added a commit that referenced this issue Sep 20, 2023
This is a quick and dirty solution to maintain a single source of truth
for the project version number. It means that builds will fail when run
outside of a git checkout, but for our current needs, that should be
fine.

Helps: #69
dylanmccall added a commit that referenced this issue Sep 20, 2023
This is a quick and dirty solution to maintain a single source of truth
for the project version number. It means that builds will fail when run
outside of a git checkout, but for our current needs, that should be
fine.

Helps: #69
@dylanmccall
Copy link
Contributor

dylanmccall commented Sep 20, 2023

I made #74 as a quick and easy solution to that version number for the desktop app itself being out of sync. It includes a change to the README, with a workflow that uses bump2version when doing releases. Just like we do with other projects in this neighbourhood such as kolibri-explore-plugin.

dylanmccall added a commit that referenced this issue Sep 20, 2023
This adds a new workflow for creating releases, with a VERSION file
that acts as a single source of truth for the project version number.

Helps: #69
dylanmccall added a commit that referenced this issue Sep 20, 2023
This adds a new workflow for creating releases, with a VERSION file
that acts as a single source of truth for the project version number.

Helps: #69
dylanmccall added a commit that referenced this issue Sep 20, 2023
This adds a new workflow for creating releases, with a VERSION file
that acts as a single source of truth for the project version number.

Helps: #69
@dbnicholson
Copy link
Member

I don't think we should do tie the endless-key-flatpak version to the kolibri-explore-plugin version. What do we call the version when we make changes beyond kolibri-explore-plugin releases? It also essentially means we need to make an endless-key-flatpak release every time we make a kolibri-explore-plugin release. Otherwise the versions will be mismatched again. Which then ripples through to the org.endlessos.Key flathub build. We should be able to make new org.endlessos.Key releases when the explore releases but not endless-key-flatpak.

I think it would be better if we had a way to specify the app version to the explore plugin so it could show that in addition to (or instead of) the plugin version.

dylanmccall added a commit that referenced this issue Oct 23, 2023
To provide a single source of information about the app, this commit
adds debug info to the About dialog in the form of a JSON object dump.
It includes the version of the application itself, the versions of
essential Python modules, and runtime information about the Kolibri
daemon service.

Helps: #69
dylanmccall added a commit that referenced this issue Oct 23, 2023
Instead of "kolibri_version (app_version)", show only the app version
in the About dialog. Detailed version information is now listed in the
troubleshooting section.

Helps: #69
dylanmccall added a commit that referenced this issue Oct 23, 2023
To provide a single source of information about the app, this commit
adds debug info to the About window in the form of a JSON object dump.
It includes the version of the application itself, the versions of
essential Python modules, and runtime information about the Kolibri
daemon service.

Helps: #69
dylanmccall added a commit that referenced this issue Oct 23, 2023
Instead of "kolibri_version (app_version)", show only the app version
in the About window. Detailed version information is now listed in the
troubleshooting section.

Helps: #69
dylanmccall added a commit that referenced this issue Oct 25, 2023
dylanmccall added a commit that referenced this issue Oct 25, 2023
dylanmccall added a commit that referenced this issue Oct 25, 2023
dylanmccall added a commit that referenced this issue Oct 25, 2023
Instead of showing the project version, which is always one version
behind, the version in the About dialog will appear as the output of
`git describe --dirty`.

Helps: #69
dylanmccall added a commit that referenced this issue Oct 25, 2023
To provide a single source of information about the app, this commit
adds debug info to the About window in the form of a JSON object dump.
It includes the version of the application itself, the versions of
essential Python modules, and runtime information about the Kolibri
daemon service.

Helps: #69
dylanmccall added a commit that referenced this issue Oct 25, 2023
Instead of "kolibri_version (app_version)", show only the app version
in the About window. Detailed version information is now listed in the
troubleshooting section.

Helps: #69
dylanmccall added a commit that referenced this issue Oct 25, 2023
Instead of showing the project version, which is always one version
behind, the version in the About dialog will appear as the output of
`git describe --dirty`.

Helps: #69
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 24, 2024
This adds a new workflow for creating releases, with a VERSION file
that acts as a single source of truth for the project version number.

Helps: endlessm/endless-key-flatpak#69
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 24, 2024
To provide a single source of information about the app, this commit
adds debug info to the About window in the form of a JSON object dump.
It includes the version of the application itself, the versions of
essential Python modules, and runtime information about the Kolibri
daemon service.

Helps: endlessm/endless-key-flatpak#69
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 24, 2024
Instead of showing the project version, which is always one version
behind, the version in the About dialog will appear as the output of
`git describe --dirty`.

Helps: endlessm/endless-key-flatpak#69
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 25, 2024
To provide a single source of information about the app, this commit
adds debug info to the About window in the form of a JSON object dump.
It includes the version of the application itself, the versions of
essential Python modules, and runtime information about the Kolibri
daemon service.

Helps: endlessm/endless-key-flatpak#69
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue Apr 25, 2024
Instead of showing the project version, which is always one version
behind, the version in the About dialog will appear as the output of
`git describe --dirty`.

Helps: endlessm/endless-key-flatpak#69
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
This adds a new workflow for creating releases, with a VERSION file
that acts as a single source of truth for the project version number.

Helps: endlessm/endless-key-flatpak#69
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
To provide a single source of information about the app, this commit
adds debug info to the About window in the form of a JSON object dump.
It includes the version of the application itself, the versions of
essential Python modules, and runtime information about the Kolibri
daemon service.

Helps: endlessm/endless-key-flatpak#69
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 4, 2024
Instead of showing the project version, which is always one version
behind, the version in the About dialog will appear as the output of
`git describe --dirty`.

Helps: endlessm/endless-key-flatpak#69
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 23, 2024
This adds a new workflow for creating releases, with a VERSION file
that acts as a single source of truth for the project version number.

Helps: endlessm/endless-key-flatpak#69
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 23, 2024
To provide a single source of information about the app, this commit
adds debug info to the About window in the form of a JSON object dump.
It includes the version of the application itself, the versions of
essential Python modules, and runtime information about the Kolibri
daemon service.

Helps: endlessm/endless-key-flatpak#69
dylanmccall added a commit to learningequality/kolibri-installer-gnome that referenced this issue May 23, 2024
Instead of showing the project version, which is always one version
behind, the version in the About dialog will appear as the output of
`git describe --dirty`.

Helps: endlessm/endless-key-flatpak#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants