Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel description in the Discovery page is not well presented #42

Open
vanessa-chang opened this issue Sep 12, 2023 · 4 comments
Open
Labels
bug Something isn't working

Comments

@vanessa-chang
Copy link

vanessa-chang commented Sep 12, 2023

Test package: https://github.com/endlessm/endless-key-flatpak/actions/runs/6153210584

When the app is started, the channel description in shown in the Discovery page. They are not well presenting.

Screenshot from 2023-09-12 16-56-39

note if you switch to the Library tab then return to the Discovery page, the description will disappear.

*This issue can be reproduced at each time you launch the app.

@vanessa-chang vanessa-chang added the bug Something isn't working label Sep 12, 2023
@vanessa-chang
Copy link
Author

It's also notice that the text font is not well presenting too. It's not aglined with how it presents in the Chromebook and Windows.

@dylanmccall
Copy link
Contributor

For anyone debugging this, there's a convenient way to turn on dev tools with the Endless Key app:

env ENDLESS_KEY_APP_DEVELOPER_EXTRAS=1 flatpak run org.endlessos.Key

Or (for a .Devel build):

env ENDLESS_KEY_DEVEL_APP_DEVELOPER_EXTRAS=1 flatpak run org.endlessos.Key.Devel

Now, there is a convenient "Inspect Element" option in the right click menu.

@dylanmccall
Copy link
Contributor

Looks like the stuff you noted about fonts has a duplicate issue over here: endlessm/kolibri-explore-plugin#810. There are a few other issues in here, although I'm not sure any of the other ones are likely to be issues of endless-key-flatpak itself.

@dbnicholson
Copy link
Member

Although it would be good to make the channel descriptions nicer, I think this is really endlessm/kolibri-explore-plugin#799. I.e., they shouldn't be shown at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants