Request missing subpath when built with two leading slashes

[smac89]

I was soo perplexed by this until I realized that httpx was ignoring part of the path that was used to build the request.

The client was built with the following:

httpx.Client(base_url='http://127.0.0.1:8282/Foo')

Then I built a request using the following:

client.build_request("GET", "//foobar/dev03/image.jpeg")

This was indeed a typo, which I didn't see at the time. However, it turns out that when this request is built, the url turns out to be:

http://127.0.0.1:8282/Foo/dev03/image.jpeg

It has essentially stripped off the //foobar part. I was quite confused for some time why it does that, until I started debugging.

Is this a bug, or expected behavior? I certainly didn't expect it.

[lovelydinosaur]

Is this a bug, or expected behavior?

Personally I think it's a misdesign, and that base_url should only allow <scheme>://<hostname>/ style URLs.

Including a path prefix is always confusing because it's non-obvious if the behaviour will be a strict URL join or some form of URL append.

Eg. what behavior is expected for...

client = Client(base_url="https://www.example.com/that")
response = client.get("/this")

I certainly didn't expect it.

Yeah it's a confusing part of the API, and yes it does look like you've found yourself a corner-case bit of particularly broken behavior.