httpcore 1.0.5 does not work with uvicorn[standard] and pytest-httpx

[hiddevdm]

Hi all,

Pytest seems to be unable to start since the httpcore plugin wants to import h11, which is not used with uvicorn[standard] (instead of h11, httptools is used).

Reverting to 1.0.4 resolves the problem.

Setup

[tool.poetry.dependencies]
python = ">=3.12,<3.13"
httpx = "0.27.0"  # comes with httpcore 1.0.5
pytest-httpx = "0.30.0"
uvicorn = { version = "0.29.0", extras = ["standard"] }
pytest = "^8"

When I define a simple test and try to run it, I get the following error:

def test_something():
    assert True

Traceback (most recent call last):
    sys.exit(pytest.main(args, plugins_to_load + [Plugin]))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 155, in main
    config = _prepareconfig(args, plugins)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 337, in _prepareconfig
    config = pluginmanager.hook.pytest_cmdline_parse(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/pluggy/_hooks.py", line 501, in __call__
    return self._hookexec(self.name, self._hookimpls.copy(), kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/pluggy/_manager.py", line 119, in _hookexec
    return self._inner_hookexec(hook_name, methods, kwargs, firstresult)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/pluggy/_callers.py", line 138, in _multicall
    raise exception.with_traceback(exception.__traceback__)
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/pluggy/_callers.py", line 121, in _multicall
    teardown.throw(exception)  # type: ignore[union-attr]
    ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/_pytest/helpconfig.py", line 105, in pytest_cmdline_parse
    config = yield
             ^^^^^
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/pluggy/_callers.py", line 102, in _multicall
    res = hook_impl.function(*args)
          ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 1143, in pytest_cmdline_parse
    self.parse(args)
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 1492, in parse
    self._preparse(args, addopts=addopts)
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/_pytest/config/__init__.py", line 1379, in _preparse
    self.pluginmanager.load_setuptools_entrypoints("pytest11")
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/pluggy/_manager.py", line 414, in load_setuptools_entrypoints
    plugin = ep.load()
             ^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.12.2_1/Frameworks/Python.framework/Versions/3.12/lib/python3.12/importlib/metadata/__init__.py", line 205, in load
    module = import_module(match.group('module'))
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/homebrew/Cellar/[email protected]/3.12.2_1/Frameworks/Python.framework/Versions/3.12/lib/python3.12/importlib/__init__.py", line 90, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen importlib._bootstrap>", line 1387, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1360, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1331, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 935, in _load_unlocked
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/_pytest/assertion/rewrite.py", line 178, in exec_module
    exec(co, module.__dict__)
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/pytest_httpx/__init__.py", line 4, in <module>
    import httpx
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/httpx/__init__.py", line 2, in <module>
    from ._api import delete, get, head, options, patch, post, put, request, stream
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/httpx/_api.py", line 6, in <module>
    from ._client import Client
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/httpx/_client.py", line 32, in <module>
    from ._transports.default import AsyncHTTPTransport, HTTPTransport
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/httpx/_transports/default.py", line 32, in <module>
    import httpcore
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/httpcore/__init__.py", line 1, in <module>
    from ._api import request, stream
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/httpcore/_api.py", line 5, in <module>
    from ._sync.connection_pool import ConnectionPool
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/httpcore/_sync/__init__.py", line 1, in <module>
    from .connection import HTTPConnection
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/httpcore/_sync/connection.py", line 14, in <module>
    from .http11 import HTTP11Connection
  File "/dev/python/test/bug/venv/lib/python3.12/site-packages/httpcore/_sync/http11.py", line 17, in <module>
    import h11
ModuleNotFoundError: No module named 'h11'

[tomchristie]

Sounds like the dependancies are not being correctly installed, tho no reason this would be an httpcore issue.
Nothing of significance to that has changed in the latest version.
Perhaps try poetry show and check what dependency tree it is creating?

[hiddevdm]

Hi Tom! Thanks for having a look. I think you're onto something, this is what is currently installed:

httpx 0.27.0 The next generation HTTP client.
├── anyio *
│   ├── idna >=2.8 
│   └── sniffio >=1.1 
├── certifi *
├── httpcore ==1.*
├── idna *
└── sniffio *
pytest 8.1.1 pytest: simple powerful testing with Python
├── colorama *
├── iniconfig *
├── packaging *
└── pluggy >=1.4,<2.0
pytest-httpx 0.30.0 Send responses to httpx.
├── httpx ==0.27.*
│   ├── anyio * 
│   │   ├── idna >=2.8 
│   │   └── sniffio >=1.1 
│   ├── certifi * 
│   ├── httpcore ==1.* 
│   ├── idna * (circular dependency aborted here)
│   └── sniffio * (circular dependency aborted here)
└── pytest >=7,<9
    ├── colorama * 
    ├── iniconfig * 
    ├── packaging * 
    └── pluggy >=1.4,<2.0 
uvicorn 0.29.0

pip freeze

anyio==4.3.0
certifi==2024.2.2
httpcore==1.0.5
httpx==0.27.0
idna==3.6
iniconfig==2.0.0
packaging==24.0
pluggy==1.4.0
pytest==8.1.1
pytest-httpx==0.30.0
sniffio==1.3.1
uvicorn==0.29.0

It seems like poetry is not picking up uvicorn[standard] properly since uvloop and httptools are nowhere to be found. After running pip install 'uvicorn[standard]' the test works properly. I'll dive deeper into what poetry is doing

[tomchristie]

I'll dive deeper into what poetry is doing

Yeah, curious that it's not picking up the httpcore dependancies? (It's already got certifi from elsewhere, tho where's h11?...)

[hiddevdm]

After some digging it turns out it was related to a recent switch to Artifactory, a private package repository (with proxy to pypi) which had some caching issues. Clearing all poetry caches resolved the issue and all extra's are installed now.

[hiddevdm]

Some background info here: python-poetry/poetry#9266 (comment)