Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs at http://django-vanilla-views.org/ not up to date #72

Open
adamchainz opened this issue Oct 2, 2018 · 12 comments
Open

Docs at http://django-vanilla-views.org/ not up to date #72

adamchainz opened this issue Oct 2, 2018 · 12 comments

Comments

@adamchainz
Copy link
Collaborator

I just looked to adding this to a project, I was surprised to read that only Django up to 1.8 is supported on: http://django-vanilla-views.org/#requirements . This isn't the case on the repo, has the documentation build been failing?

@carltongibson
Copy link

Hey @adamchainz.

I suspect it's just a mkdocs gh-deploy (or such) — but updating is needed. (Lack of bandwidth...)

I suspect it'd all just work with an update to tox.ini (and the readme). If you want to use your superpowers to bring it up-to-date that would be amazing!

@carltongibson
Copy link

i.e. https://travis-ci.org/tomchristie/django-vanilla-views/builds/357418285 (is already 90% what's needed)

@adamchainz
Copy link
Collaborator Author

tox.ini or .travis.yml?

@carltongibson
Copy link

Ah, yes. My pet hate. 😄

Alas, the answer is probably both. (But we might argue we don't really need tox locally for development...)

@tomchristie
Copy link
Member

Just .travis.yml would be fine. I'd be okay with us dropping tox.

@tomchristie
Copy link
Member

I reckon it's worth us bringing this back up to date and getting it under the encode umbrella. https://github.com/encode/

@adamchainz
Copy link
Collaborator Author

Can I do anything to help with move to encode/updating docs?

@adamchainz
Copy link
Collaborator Author

Ok so I figured out changing the docs in #75 , #76, and #77. Currently it relies on running the mkdocs.py script in the repo (not mkdocs the tool, perhaps an early prototype @tomchristie ?) and copying the results over to the gh-pages branch as I did in #77. They're up to date now at least.

@tomchristie can you give me access to the repo settings, then I'll move them to HTTPS using the new free Lets Encrypt on github pages :)

@tomchristie
Copy link
Member

@adamchainz I don't think I can do that against a personal repo.
What do you need, just enforcing HTTPS?

screenshot 2019-01-03 at 11 41 46

Settings currently look like this, I think it means I need to first update the DNS records.

@adamchainz
Copy link
Collaborator Author

Fair enough, yeah you can't make me admin of a personal repo. And yes, it looks like you might need to go through custom domain setup to find some new DNS records to add, so they can LetsEncrypt.

@adamchainz
Copy link
Collaborator Author

I've just updated the docs for the 1.1.0 release.

If you could check "Enforce HTTPS" @tomchristie that'd be neat.

@adamchainz
Copy link
Collaborator Author

adamchainz commented Jul 8, 2020

@tomchristie I appreciate you're busy - perhaps you could add me as collaborator on the repo so I can do this and not ask you for other things in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants