Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building in a path containing spaces does not work #33

Open
kjellwinblad opened this issue Jun 27, 2022 · 2 comments
Open

Building in a path containing spaces does not work #33

kjellwinblad opened this issue Jun 27, 2022 · 2 comments

Comments

@kjellwinblad
Copy link
Contributor

When trying to build this repository from a path containing spaces, it does not work.

How to reproduce:

mkdir "path with spaces"
git clone https://github.com/emqx/jq.git
cd jq
rebar3 compile
kjellwinblad added a commit to kjellwinblad/jq that referenced this issue Jul 8, 2022
@kjellwinblad
build: make makefile work even if there are spaces in its path
c9efe35 
This is a partial fix for:

emqx#33

Unfortunately, the jq library itself does not compile when there are
spaces in its path so we have to fix this issue in EMQX's jq fork before
the above issue is completely fixed. See:

jqlang/jq#2453
@kjellwinblad kjellwinblad mentioned this issue Jul 8, 2022
Merged
@kjellwinblad
Copy link
Contributor Author

The problems with our makfile is fixed in #35 but the jq library still don't build with spaces in the path.

Unfortunately, this does not seems supper easy to fix as the problem might be due to inherent problems with automake build tools. See for example:

https://stackoverflow.com/questions/16194124/autoconf-spaces-in-path

@zmstone
Copy link
Member

zmstone commented Jul 8, 2022

We should focus on the runtime issue first.

I think it's fair to set a hard rule to "we do not support spaces in build path"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zmstone @kjellwinblad