Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add exit tips for conn #1821

Merged
merged 1 commit into from
Dec 3, 2024
Merged

feat(cli): add exit tips for conn #1821

merged 1 commit into from
Dec 3, 2024

Conversation

ysfscream
Copy link
Member

@ysfscream ysfscream commented Dec 2, 2024

PR Checklist

If you have any questions, you can refer to the Contributing Guide

What is the current behavior?

When users successfully establish a connection using the mqttx conn command, the program maintains the connection state (appearing to be "hanging"). Still, there is no prompt for users to exit. This causes users to need clarification about the program's behavior.

  • Users are unclear that the expected behavior of the mqttx conn command is to maintain the connection
  • Users don't know how to exit the connection state properly
  • Lack of user guidance leads to poor operational experience

Please describe the current behavior and link to a relevant issue.

Issue Number

Example: #1810

What is the new behavior?

❯ mqttx conn
✔ Connected
- Press Ctrl+C to disconnect and exit

Please describe the new behavior or provide screenshots.

Does this PR introduce a breaking change?

  • Yes
  • No

Specific Instructions

Are there any specific instructions or things that should be known prior to review?

Other information

@ysfscream ysfscream added enhancement New feature or request feature This pr is a feature CLI MQTTX CLI labels Dec 2, 2024
@ysfscream ysfscream added this to the v1.11.1 milestone Dec 2, 2024
@ysfscream ysfscream requested a review from Red-Asuka December 2, 2024 16:48
@ysfscream ysfscream self-assigned this Dec 2, 2024
@Red-Asuka Red-Asuka merged commit dcd8435 into main Dec 3, 2024
6 checks passed
@Red-Asuka Red-Asuka deleted the ysf/cli branch December 3, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI MQTTX CLI enhancement New feature or request feature This pr is a feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants