Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@emotion/eslint-plugin should support eslint 9 #3211

Open
Keysox opened this issue Jul 12, 2024 · 0 comments · May be fixed by #3248
Open

@emotion/eslint-plugin should support eslint 9 #3211

Keysox opened this issue Jul 12, 2024 · 0 comments · May be fixed by #3248

Comments

@Keysox
Copy link

Keysox commented Jul 12, 2024

The problem

ESLint v9.0.0 was released back in April and we'd like to use @emotion/eslint-plugin but npm complains:

npm error Could not resolve dependency:
npm error peer eslint@"6 || 7 || 8" from @emotion/[email protected]

Proposed solution

It would be great if we could update

"eslint": "6 || 7 || 8"
to "eslint": ">=6" so that we're able to upgrade when new versions of ESLint come out today and into the future.

Alternative solutions

Alternatively, we could change it to "eslint": "6 || 7 || 8 || 9"

Additional context

I haven't tested whether this package works with new ESLint so perhaps there's a reason to not update the peer. If that's the case, it would be great to update what's needed for compatability!

soren121 added a commit to soren121/emotion that referenced this issue Aug 27, 2024
soren121 added a commit to soren121/emotion that referenced this issue Aug 27, 2024
@soren121 soren121 linked a pull request Aug 27, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant