Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting enter key on numeric pad. #1987

Open
ruimo opened this issue Aug 30, 2022 · 5 comments · May be fixed by #5616
Open

Supporting enter key on numeric pad. #1987

ruimo opened this issue Aug 30, 2022 · 5 comments · May be fixed by #5616
Labels
feature New feature or request

Comments

@ruimo
Copy link

ruimo commented Aug 30, 2022

Is your feature request related to a problem? Please describe.
No, this is not related to any problems.

Describe the solution you'd like
eframe::egui::Key::Enter does not fire if enter key on numeric pad is pressed. Add eframe::egui::Key::NumEnter that is fired if enter key on numeric pad is hit.

Describe alternatives you've considered
Firing eframe::egui::Key::Enter when enter key on numeric pad too can be an alternative (does not add new event code).

Additional context
None.
@ruimo ruimo added the feature New feature or request label Aug 30, 2022
@Ryder17z
Copy link

Ryder17z commented Aug 30, 2022 •
edited
Loading

Preferably you would have:

  • AnyEnter
  • NumEnter
  • Enter

that makes the most sense for modifiers as well (Any, Left, Right)

@yerke
Copy link
Contributor

yerke commented Oct 16, 2022

Hi @emilk. Thanks for your work on egui. Are you interested in getting a PR for supporting NumEnter (enter from numpad)? If so, can you please share your thoughts on how you would prefer it work? Are you ok with a new Key::NumEnter?
Right now there is no easy way to work around this issue, as far as I understand.
Thanks.

@wiz21b
Copy link

wiz21b commented Apr 29, 2023

I'd like to vote for this issue. In my case, I expect my user to type in numbers and therefore to prefer to use the keypad Enter rather than the regular Enter.

@atbrakhi atbrakhi mentioned this issue Aug 21, 2023
Merged
3 tasks
@atbrakhi atbrakhi mentioned this issue Aug 29, 2023
Open
27 tasks
@emilk
Copy link
Owner

emilk commented Jan 9, 2024

I think adding a Key::NumpadEnter makes sense, and then also check for that wherever we currently check for Key::Enter

@Ryder17z
Copy link

Ryder17z commented Jan 9, 2024

AnyEnter would be nice to have too, like mentioned above.

@yerke yerke linked a pull request Jan 18, 2025 that will close this issue
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Key::NumpadEnter yerke/egui
5 participants
@wiz21b @emilk @ruimo @Ryder17z @yerke