Ctrl+Shift+Z should restore data to the state that was before like Ctrl+Y does

[AngelicosPhosphoros]

Is your feature request related to a problem? Please describe.

Well, I often use keybinding Ctrl+Shift+Z to restore text state after I accidentally undid too much changes using Ctrl+Z. In egui controls, e.g. text edit, Ctrl+Shift+Z doesn't behave like rest of such inputs in my system (Windows 10).

Describe the solution you'd like
Ctrl+Shift+Z keybinding should do redo operation, like Ctrl+Y does.

Describe alternatives you've considered
Do nothing and tell users to use Ctrl+Y. It works on egui controls.

Additional context
Well, I use computers the biggest part of my life and always used Ctrl+Shift+Z to cancel Ctrl+Z. Only when opening this issue, I checked if this is actually standardized and found that there exists a Ctrl+Y keybinding. I think, it is common for users to be like me so supporting both Ctrl+Y and Ctrl+Shift+Z would be convenient for them.

Maybe, it is a wrong repository to report this and I should report it to winit, I don't really know.

[YgorSouza]

No, this has nothing to do with winit, and it's actually a bug in egui. The Ctrl+Shift+Z shortcut is supposed to work as redo as well:

egui/crates/egui/src/widgets/text_edit/builder.rs

Lines 997 to 1015 in 23728e1

	Event::Key {
	key,
	pressed: true,
	modifiers,
	..
	} if (modifiers.matches_logically(Modifiers::COMMAND) && *key == Key::Y)
	|| (modifiers.matches_logically(Modifiers::SHIFT | Modifiers::COMMAND)
	&& *key == Key::Z) =>
	{
	if let Some((redo_ccursor_range, redo_txt)) = state
	.undoer
	.lock()
	.redo(&(cursor_range.as_ccursor_range(), text.as_str().to_owned()))
	{
	text.replace_with(redo_txt);
	Some(*redo_ccursor_range)
	} else {
	None
	}

But it doesn't, because the previous match arm (undo) is also triggered by this same key combination:

egui/crates/egui/src/widgets/text_edit/builder.rs

Lines 980 to 996 in 23728e1

	Event::Key {
	key: Key::Z,
	pressed: true,
	modifiers,
	..
	} if modifiers.matches_logically(Modifiers::COMMAND) => {
	if let Some((undo_ccursor_range, undo_txt)) = state
	.undoer
	.lock()
	.undo(&(cursor_range.as_ccursor_range(), text.as_str().to_owned()))
	{
	text.replace_with(undo_txt);
	Some(*undo_ccursor_range)
	} else {
	None
	}
	}

This matches_logically method is supposed to work like this, at least according to its doctests:

egui/crates/egui/src/data/input.rs

Lines 769 to 786 in 23728e1

	/// ## Behavior:
	/// ```
	/// # use egui::Modifiers;
	/// assert!(Modifiers::CTRL.matches_logically(Modifiers::CTRL));
	/// assert!(!Modifiers::CTRL.matches_logically(Modifiers::CTRL | Modifiers::SHIFT));
	/// assert!((Modifiers::CTRL | Modifiers::SHIFT).matches_logically(Modifiers::CTRL));
	/// assert!((Modifiers::CTRL | Modifiers::COMMAND).matches_logically(Modifiers::CTRL));
	/// assert!((Modifiers::CTRL | Modifiers::COMMAND).matches_logically(Modifiers::COMMAND));
	/// assert!((Modifiers::MAC_CMD | Modifiers::COMMAND).matches_logically(Modifiers::COMMAND));
	/// assert!(!Modifiers::COMMAND.matches_logically(Modifiers::MAC_CMD));
	/// ```
	pub fn matches_logically(&self, pattern: Self) -> bool {
	if pattern.alt && !self.alt {
	return false;
	}
	if pattern.shift && !self.shift {
	return false;
	}

But it is being used incorrectly here, causing both Ctrl+Z and Ctrl+Shift+Z to work as undo.

[Mingun]

This code looks awful

egui/crates/egui/src/widgets/text_edit/builder.rs

Lines 1002 to 1004 in 23728e1

	} if (modifiers.matches_logically(Modifiers::COMMAND) && *key == Key::Y)
	|| (modifiers.matches_logically(Modifiers::SHIFT | Modifiers::COMMAND)
	&& *key == Key::Z) =>

I would be better introduce a Shortcut struct which will incapsulate keys and modifiers. QShortcut is a good inspiration.

[YgorSouza]

There is https://docs.rs/egui/0.29.1/egui/struct.KeyboardShortcut.html. Not sure why it isn't being used here. Maybe it was introduced later and this code was never refactored. But that is a separate issue.