Skip to content
This repository has been archived by the owner on Oct 25, 2021. It is now read-only.

Skip setting properties that haven't changed #37

Open
emersion opened this issue Dec 20, 2019 · 1 comment
Open

Skip setting properties that haven't changed #37

emersion opened this issue Dec 20, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@emersion
Copy link
Owner

emersion commented Dec 20, 2019 •
edited
Loading

Atomic test-only commits set property values for the next commit when they succeed. We don't need to keep setting the same property values over and over again.
@emersion emersion added the enhancement New feature or request label Dec 20, 2019
emersion added a commit that referenced this issue Jan 13, 2020
@emersion
test/libdrm_mock: a test-only commit applies properties
b160787 
The previous mock library assumed the DRM client would always set all
properties in the atomic request. However, if a previous test-only commit
has set a property, there's no need to set it again.

Accomodate for this in libdrm_mock. This will be useful when we'll skip
setting properties that haven't changed in libliftoff.

References: #37
@emersion
Copy link
Owner Author

emersion commented May 22, 2020 •
edited
Loading

Atomic test-only commits set property values for the next commit when they succeed.

Nope, that's false. Was confused because wlroots re-used the atomic requests between commits.

Only regular commits set property values for subsequent commits.

Another thing to keep in mind is that a VT switch messing up our previous state may happen at any time. Also there's no guarantee the compositor has performed a regular atomic commit after liftoff_output_apply.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emersion