You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Embroider addon blueprint supports template tag out of the box. So we need to extend Ember CLI's Prettier configuration to support .gjs and *.gts files as well. I think it should look like the following:
I noticed a mismatch of the Prettier config between Ember CLI and Embroider addon blueprint.
Embroider addon blueprint configures Prettier to use single quotes for every file type:
addon-blueprint/files/.prettierrc.cjs
Lines 3 to 6 in b1168b4
addon-blueprint/files/__addonLocation__/.prettierrc.cjs
Lines 3 to 6 in b1168b4
Ember CLI blueprints configure Prettier to use single quotes only for JavaScript and TypeScript files:
https://github.com/ember-cli/ember-cli/blob/f824a6aee6e804fe4584fb037e893e3bbf93370a/blueprints/app/files/.prettierrc.js#L3-L12
I think both should be aligned.
Embroider addon blueprint supports template tag out of the box. So we need to extend Ember CLI's Prettier configuration to support
.gjs
and*.gts
files as well. I think it should look like the following:If there aren't any concerns against implementing it, I can try providing a PR this week.
The text was updated successfully, but these errors were encountered: