Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glint does not support gts imports with the extension #194

Closed
NullVoxPopuli opened this issue Sep 7, 2023 · 6 comments
Closed

Glint does not support gts imports with the extension #194

NullVoxPopuli opened this issue Sep 7, 2023 · 6 comments

Comments

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Sep 7, 2023

This is more a tracking issue, as I think Glint would need to solve this.

But I have a repro here: universal-ember/ember-primitives#114

error looks like this:

[js] created dist in 738ms
[js] npm run build:js exited with code 0
[types] src/components/portal.gts:4:49 - error TS2307: Cannot find module './portal-targets.gts' or its corresponding type declarations.
[types] 
[types] 4 import { findNearestTarget, type TARGETS } from './portal-targets.gts';
[types]                                                   ~~~~~~~~~~~~~~~~~~~~~~
[types] 

Note that gts extensions were used in the import path to avoid needing @rollup/plugin-node-resolve

We already have:

allowImportingTsExtensions: true
```,
so I guess I'd expect it to also work for `gts` extensions? 
@simonihmig
Copy link
Collaborator

I wonder why this is not failing CI for us?

We run linting on the typescript scenario here, and the fixtures have this .gts import, so shouldn't that have failed Glint and thus the linting script?

@NullVoxPopuli
Copy link
Collaborator Author

lint:fix doesn' run glint. I suspect if we run lint after lint:fix, we'll have errors

@simonihmig
Copy link
Collaborator

Also this probably? #196

@NullVoxPopuli
Copy link
Collaborator Author

yup

@simonihmig
Copy link
Collaborator

Also this probably? #196

Indeed: #199

@NullVoxPopuli
Copy link
Collaborator Author

this issue is resolved now, but we now have: #215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants