Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type-tests folder to addon folder when --typescript is enabled #142

Open
NullVoxPopuli opened this issue Jul 10, 2023 · 0 comments · May be fixed by #153
Open

Add type-tests folder to addon folder when --typescript is enabled #142

NullVoxPopuli opened this issue Jul 10, 2023 · 0 comments · May be fixed by #153
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Jul 10, 2023

Library for testing types: expect-type (what ember-source uses).

Example:

Will require that we update the eslint configs (I had to do that for my own stuff here)


Open questions:

  • ember.js has a separate tsconfig.json for the type tests -- do we need this? I did not find that I needed it for ember-resources

    answer: we do need this -- ember-resources' types are generated through rollup, rather than tsc/glint

@NullVoxPopuli NullVoxPopuli added help wanted enhancement New feature or request labels Jul 13, 2023
@NullVoxPopuli NullVoxPopuli linked a pull request Jul 15, 2023 that will close this issue
@NullVoxPopuli NullVoxPopuli added good first issue Good for newcomers and removed help wanted labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant