-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test isolation validation should include canceling active test waiters in ember-test-watiers #488
Comments
I'm a bit on the fence here, while I agree that it might seem nice to have I do not think that we can actually cancel the async operation that the waiters are paused on. This means that while the waiters will not pause tests any more, you actually are in a broken state. Silently swallowing that seems extremely bad... |
Had a good chat with @rwjblue offline. We agreed that adding this API will likely result in leaks actually occurring, defeating the point of the waiters. We discussed evaluating |
@scalvert - Should we close then? |
The
ember-test-waiters
library will soon include an API to cancel all pending waiters. This is a similar concept to where we cancel timers if test isolation validation is triggered:ember-qunit/addon-test-support/ember-qunit/test-isolation-validation.js
Lines 94 to 100 in c27964a
This will help ensure that we don't leak state from one test to another, potentially 'wedging' the test waiters and creating an inconsistent state.
The text was updated successfully, but these errors were encountered: