Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App styles leak into QUnit test runner UI #485

Open
broldak opened this issue May 6, 2019 · 8 comments
Open

App styles leak into QUnit test runner UI #485

broldak opened this issue May 6, 2019 · 8 comments

Comments

@broldak
Copy link

broldak commented May 6, 2019

Because the test runner's UI and the UI of the rendered component/app are not isolated, the app styles leak into the QUnit test runner's UI. The example below shows a case where the inputs for Hide passed tests, Check for Globals, etc are rendered with no checkboxes due to some app styles.
Screen Shot 2019-05-06 at 2 44 43 PM

Ideally QUnit's styles would not affect the rendered UI in the tests and vice versa.

@rwjblue
Copy link
Member

rwjblue commented May 14, 2019

Thank you for reporting @broldak! I'm not 100% sure of the right solution here, but this is definitely quite annoying and we should try to figure out a good path forward.

@mfeckie
Copy link

mfeckie commented Jun 20, 2019

I addressed a similar problem with other styles leaking here qunitjs/qunit#1395

@rwjblue
Copy link
Member

rwjblue commented Jun 20, 2019

Hmm, @mfeckie do you think that this fixes the issue @broldak reported?

@mfeckie
Copy link

mfeckie commented Jun 21, 2019

@rwjblue I don't think it fixes the specific issue, but could be used as inspiration for an approach to resolve their issue

@Krinkle
Copy link
Contributor

Krinkle commented Aug 1, 2020

Perhaps a combination of CSS all and CSS unset or CSS revert could be of use here. I'd be open to accepting such a patch in QUnit upstream.

@rwjblue
Copy link
Member

rwjblue commented Aug 2, 2020

Thanks @Krinkle!

@spuxx1701
Copy link

Been quite a while, but the behavior still persists it seems. Any news on the issue?

@Krinkle
Copy link
Contributor

Krinkle commented Sep 14, 2022

@spuxx1701 Which QUnit version do you see in the browser when you encounter this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants