-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The "Disable Linting" checkbox does nothing #1139
Comments
I think the checkbox only ever did anything if you had ember-cli-eslint or ember-cli-template-lint -- do you have either of those? If not, we should probs find a way to remove that checkbox! Thanks for reporting! |
Ah right! ember-cli-eslint and ember-cli-template-lint are both marked as deprecated. As I see it, there's two ways of doing this. Either:
Either way, I think the checkbox needs to go. It's squatting on some valuable real-estate. I've had a go at removing the checkbox in #1140. |
In the test runner, we have a "Disable Linting" checkbox:
After creating a brand new Ember app (via
ember new
), I noticed that the "Disable Linting" checkbox has no effect. Whether it's checked or unchecked, linting doesn't happen inside the test runner.The text was updated successfully, but these errors were encountered: