Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a redirect from /colours/ to /colors/ #318

Open
mansona opened this issue Apr 29, 2020 · 4 comments
Open

Setup a redirect from /colours/ to /colors/ #318

mansona opened this issue Apr 29, 2020 · 4 comments

Comments

@mansona
Copy link
Member

mansona commented Apr 29, 2020

As a result of #315 we have updated the spelling of color in the application. This is all fine for the content but if we update any URL we should make sure that there is a redirect in place in all cases 👍

This task will be complete when https://ember-styleguide.netlify.app/concepts/colours/ redirects to https://ember-styleguide.netlify.app/concepts/colors/

Note: this implementation may not currently be implemented in field-guide 🤔 but it should be reasonably easy to port the same redirect code from Guidemaker to Field Guide

@MelSumner
Copy link
Member

@mansona since it's a bug not a feature, do you think we should use a general redirect?

@mansona
Copy link
Member Author

mansona commented Apr 29, 2020

in all cases we should include redirects, it's something that we should just be in the general habit of (in my opinion). It covers anyone who has sent any links to people, anyone who has bookmarked a page, and any related SEO concerns that we have.

It may have only been live for a very short amount of time but it the redirect should be added 👍

@alexeykostevich
Copy link
Contributor

alexeykostevich commented Apr 29, 2020

@mansona , this is totally up to the team but, please, let me share my thoughts about this.

Conceptually, ember-styleguide is not a website for general public (at least at this point) -- it is an internal website only used by the Ember Learning team and contributors. So, I think adding redirects can bring more complexity than value for this project and limit team's flexibility as the project evolves (likely, we will rename, restructure, split components, etc.).

So, since the incorrect URL navigates just to a home page, I think it is reasonable trade-off between simplicity and convenience.

However, I totally agree that this is a great practice for all public projects and user facing websites.

@mansona
Copy link
Member Author

mansona commented Apr 29, 2020

I just noticed that the incorrect URL navigates to the home page now 🙈 that is actually significantly worse because it ends up being counted as duplicate content in Google searches and that will significantly affect our rankings.

As for if this is a good or a bad idea, that's probably something to discuss at our weekly meetings 😂 I see your point that it's not "public-facing" but I would argue that having more search results for Ember addons show up when people might be searching for related terms would be a great way to improve Ember's visibility 🎉

Also, I don't think we need to worry too much about the complexity of this implementation because we have already solved it in other projects and there is little uncertainty around this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants