Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work out user authentication piece #65

Closed
acorncom opened this issue Oct 31, 2016 · 6 comments
Closed

Work out user authentication piece #65

acorncom opened this issue Oct 31, 2016 · 6 comments
Assignees
Milestone

Comments

@acorncom
Copy link
Member

This helps finish off #16

I think it'd be good to copy what Ember Twiddle is doing as much as possible (in the long run we might end up doing a shared add-on or something to make Github auth easier across all EmberJs.com "apps").

Things of interest that seem applicable to what we want to do:

We'll also want to work out what scope we would want to request for our Github OAuth app. Full details on this here: https://developer.github.com/v3/oauth/#scopes Possible options:

  • (no scope) - provides read-only info about the user (basic info, folks probably ok with giving us this info)
  • user:email - gives us access to the user's email address (possibly useful for email notifications in the future? what use cases would we have? worth discussing this further ...)
  • notifications - not sure this has many practical benefits to what we're aiming to do in the long run
@acorncom acorncom added this to the v1 milestone Oct 31, 2016
@acorncom
Copy link
Member Author

@sivakumar-kailasam Thoughts on the scope questions above?

@sivakumar-kailasam
Copy link
Member

@acorncom I'd like to ask for user:email but let users opt out of receiving notifications from within the app. Would help in the long run for these if they ever take shape - surveys, leaderboard updates, new workshop mailers. Thoughts?

@acorncom
Copy link
Member Author

@sivakumar-kailasam seems like those types of features could be nice, but is that possibility worth the "why do they need my email address o_0?" question as we ask folks to login? Theoretically we might be looking at 50-70% of the users of the tool logging in (probably more organizers than day-to-day users) ...

@sivakumar-kailasam
Copy link
Member

Sure, I've seen services notifying users reasons for changing the required scope as they introduced new features. So I guess we can always do that.

@acorncom acorncom added Help Wanted Extra attention is needed and removed Help Wanted Extra attention is needed labels Nov 3, 2016
@EndangeredMassa
Copy link
Collaborator

Is the current auth situation acceptable? No users have to auth and no repos have to do any special setup.

@sivakumar-kailasam
Copy link
Member

Yes it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants