Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for impersonating groups with flag #42

Closed
pratikkumar-mohite opened this issue Apr 9, 2024 · 2 comments
Closed

Add support for impersonating groups with flag #42

pratikkumar-mohite opened this issue Apr 9, 2024 · 2 comments

Comments

@pratikkumar-mohite
Copy link
Contributor

pratikkumar-mohite commented Apr 9, 2024

Adding support for impersonation of groups by passing --as-group through to kubectl exec/get secret cli. We use impersonation as cluster-admins to elevate access to cluster secrets and cluster exec, kubectl supports this with the --as-group flag and supporting this in view-secret makes this much easier to utilize with kubernetes RBAC.

kubectl view-secret --as=pratikkumar.mohite --as-group=system:masters  default-secret                                                         
Error: unknown flag: --as-group
@pratikkumar-mohite
Copy link
Contributor Author

@elsesiy can you assign this to me, also I've raised the PR #43 could you verify and merge?

@elsesiy
Copy link
Owner

elsesiy commented Apr 11, 2024

Implemented via #43

@elsesiy elsesiy closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants