-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language naming issue at Hide translation block #2814
Comments
Start a new pull request in StackBlitz Codeflow. |
We use ISO-639-1 library, and the library has a few entries with lower case languages. |
Okay then, so it's another issue. |
no, browser Intl functions also showing |
you can open chrome/firefox dev tools (pressing F12 key), then paste this code on console tab: new Intl.DisplayNames(
['hu'],
{ type: 'language', languageDisplay: 'standard', localeMatcher: 'lookup' },
).of('hu') and new Intl.DisplayNames(
['hu-HU'],
{ type: 'language', languageDisplay: 'standard', localeMatcher: 'lookup' },
).of('hu-HU') Chrome: Firefox: |
https://mastodon.social/settings/preferences/appearance This is the same in Mastodon UI. I think those language names are written in each language. Although I have little knowledge of Hungarian, I guess the lowercase one ("magdar") is a formal spelling in Hungarian in terms of the language name? Wiktionary also writes "magdar" in Hungarian but "Magdar" is English spelling. ref.
|
magyar is a noun, but Magyarország is proper noun in English. |
When "magyar" is not a wrong case, I think the confusion is due to inconsistency with the above "Language" section. This capitalized one is hardcoded here: Lines 121 to 125 in c56d6b1
so we should use the same case as the below ISO 639-1's ones. |
@shuuji3 as I mention, we use Maybe we can update i18n.ts module to use same lang names. |
Yes, that's my understanding👍🏻 Can I try updating |
It is a style thing or it is language thing to have the first letter uppercase in lists? As a designer it is more important to have all first letter uppercase. I propose Magyar could be better in every language related list IMHO. And also important to have the same usage in every circumstances. It's only my opinion, I do not want to intervene in Elk development. |
@iamdtms it is a problem with the language: for example, week days in Spanish are no proper names (in Spain) and so the names should be in lowercase (with some exceptions), but anyone may want to use first letter in uppercase: |
selector:first-letter { text-transform: uppercase } also an option for proper display with no text replacement? |
That From |
I understand. Good luck with that multilingual thing. |
I'm going to prepare a PR to use |
Thank you! |
In Settings > Language > At the 'Hide specific translations' block Hungarian language starts with a lowercase letter, need to replace Uppercase letter. I did not found it in the hu-HU.json file. Screenshot attachment also available.
Thank you!
The text was updated successfully, but these errors were encountered: