Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: expose splitter parameters to args #1

Open
xenotropic opened this issue Mar 18, 2023 · 1 comment
Open

Feature request: expose splitter parameters to args #1

xenotropic opened this issue Mar 18, 2023 · 1 comment

Comments

@xenotropic
Copy link

I initially just tried the instructions (put long files in put_audio_files_here), and got nothing, just an output line of omitting [filename] for each of my two files. Upon investigation, it seemed like I needed to make the splitter parameters more sensitive: to split on less-quiet and/or shorter silences. To do that I have to edit those params in two different places. It would make the tool more usable if those parameters (minimum silence length and threshold) were arguments that could be passed in to audiosplitter.py and/or pipeline.py.

@osok
Copy link

osok commented Feb 6, 2024

I have this addressed in my fork. I already made one pull request. Once that gets accepted I'll make another to add this functionality. Meanwhile you can grab the code from my repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants