run script on temp file #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it would only run on the saved file, meaning if you ran it and had unsaved changes, those changes would be lost. This copies the text to a temp file, runs eslint --fix on that, and returns the results
|
This would cause ESLint to be running on the file from |
|
oh yeah good point, give me a bit |
the correct eslint config is now used. stilll uses the os temp directory on unsaved files
|
Ok check it now, fixed the issue |
|
Hey, any updates or comments on this PR? |
|
It seems to me like there's a risk that the eslint configuration will ignore certain patterns of files, and that it's difficult to guarantee that the temporary file created will match that pattern. What do you think about fixing this via #34 instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would only run on the saved file, meaning if you ran it and had unsaved changes, those changes would be lost. This copies the text to a temp file, runs eslint --fix on that, and returns the results