fix potential buffer overflow

Author: elfmz

filecase/src/FileCase.hpp

@@ -34,7 +34,7 @@ const TCHAR *GetMsg(int MsgId);
 void InitDialogItems(const struct InitDialogItem *Init, struct FarDialogItem *Item, int ItemsNumber);
 int IsCaseMixed(const TCHAR *Str);
 const TCHAR *GetOnlyName(const TCHAR *FullName);
-TCHAR *GetFullName(TCHAR *Dest, const TCHAR *Dir, const TCHAR *Name);
+TCHAR *GetFullName(size_t DestLen, TCHAR *Dest, const TCHAR *Dir, const TCHAR *Name);
 void CaseWord(TCHAR *nm, int Type);
 void ProcessName(const TCHAR *OldFullName, DWORD FileAttributes);
 

filecase/src/FileMix.icpp

@@ -61,17 +61,17 @@ const TCHAR *GetOnlyName(const TCHAR *FullName)
 	return Name;
 }
 
-TCHAR *GetFullName(TCHAR *Dest,const TCHAR *Dir,const TCHAR *Name)
+TCHAR *GetFullName(size_t DestLen, TCHAR *Dest,const TCHAR *Dir,const TCHAR *Name)
 {
-	lstrcpy(Dest,Dir);
-	int len=lstrlen(Dest);
+	lstrcpyn(Dest,Dir,DestLen);
+	int len = DestLen ? std::min(lstrlen(Dest), DestLen - 1) : 0;
 	if(len)
 	{
 		if(Dest[len-1]==_T('/')) --len;
 		else Dest[len]=_T('/');
-		lstrcpy(Dest+len+1,GetOnlyName(Name));
+		lstrcpyn(Dest+len+1,GetOnlyName(Name),DestLen-len-1);
 	}
-	else lstrcpy(Dest, Name);
+	else lstrcpyn(Dest, Name, DestLen);
 
 	return Dest;
 }

filecase/src/ProcessName.icpp

@@ -80,7 +80,7 @@ void ProcessName(const TCHAR *OldFullName, DWORD FileAttributes)
 #ifdef UNICODE
 				ProcessName(Items[I].lpwszFileName,Items[I].dwFileAttributes);
 #else
-				GetFullName(NewFullName,OldFullName,Items[I].FindData.cFileName);
+				GetFullName(ARRAYSIZE(NewFullName),NewFullName,OldFullName,Items[I].FindData.cFileName);
 				ProcessName(NewFullName,Items[I].FindData.dwFileAttributes);
 #endif
 			}

filecase/src/filecvt.icpp

@@ -141,7 +141,7 @@ void CaseConversion()
 				{
 					Info.Control(PANEL_ACTIVE,FCTL_GETSELECTEDPANELITEM,I,(LONG_PTR)PPI);
 #endif
-				GetFullName(FullName,CurDir,FileName);
+				GetFullName(ARRAYSIZE(FullName),FullName,CurDir,FileName);
 				ProcessName(FullName,FileAttr);
 #ifdef UNICODE
 					free(PPI);