copy: re-create device nodes for fifo, character and block devices instead of copying them (thats typically bad idea) (fix #1907)

Author: elfmz

WinPort/src/sudo/sudo_client_api.cpp

@@ -802,10 +802,10 @@ extern "C" __attribute__ ((visibility("default"))) int sdc_fsetxattr(int fd, con
 	}
 	return r;
 #endif
- }
+}
 
- extern "C" __attribute__ ((visibility("default"))) int sdc_fs_flags_set(const char *path, unsigned long flags)
- {
+extern "C" __attribute__ ((visibility("default"))) int sdc_fs_flags_set(const char *path, unsigned long flags)
+{
 #if defined(__CYGWIN__) || defined(__HAIKU__)
 	//TODO
 	return 0;
@@ -842,7 +842,59 @@ extern "C" __attribute__ ((visibility("default"))) int sdc_fsetxattr(int fd, con
 
 	return r;
 #endif
- }
+}
+
+extern "C" __attribute__ ((visibility("default"))) int sdc_mkfifo(const char *path, mode_t mode)
+{
+	ClientReconstructCurDir crcd(path);
+	int r = mkfifo(path, mode);
+	if (r == 0 || !IsAccessDeniedErrno() || !TouchClientConnection(true)) {
+		return r;
+	}
+
+	try {
+		ClientTransaction ct(SUDO_CMD_MKFIFO);
+		ct.SendStr(path);
+		ct.SendPOD(mode);
+
+		r = ct.RecvInt();
+		if (r != 0)
+			ct.RecvErrno();
+
+	} catch(std::exception &e) {
+		fprintf(stderr, "sudo_client: sdc_mkfifo('%s', 0x%lx) - error %s\n",
+			path, (unsigned long)mode, e.what());
+		r = -1;
+	}
+
+	return r;
+}
+
+extern "C" __attribute__ ((visibility("default"))) int sdc_mknod(const char *path, mode_t mode, dev_t dev)
+{
+	ClientReconstructCurDir crcd(path);
+	int r = mknod(path, mode, dev);
+	if (r == 0 || !IsAccessDeniedErrno() || !TouchClientConnection(true)) {
+		return r;
+	}
+
+	try {
+		ClientTransaction ct(SUDO_CMD_MKNOD);
+		ct.SendStr(path);
+		ct.SendPOD(mode);
+		ct.SendPOD(dev);
+
+		r = ct.RecvInt();
+		if (r != 0)
+			ct.RecvErrno();
+	} catch(std::exception &e) {
+		fprintf(stderr, "sudo_client: sdc_mknod('%s', 0x%lx, 0x%lx) - error %s\n",
+			path, (unsigned long)mode, (unsigned long)dev, e.what());
+		r = -1;
+	}
+
+	return r;
+}
 
 
 } //namespace Sudo

WinPort/src/sudo/sudo_dispatcher.cpp

@@ -342,6 +342,34 @@ namespace Sudo
 		}
 		bt.SendInt(r);
 	}
+
+	static void OnSudoDispatch_MkFifo(BaseTransaction &bt)
+	{
+		std::string path;
+		mode_t mode;
+		bt.RecvStr(path);
+		bt.RecvPOD(mode);
+		int r = mkfifo(path.c_str(), mode);
+		bt.SendInt(r);
+		if (r != 0) {
+			bt.SendErrno();
+		}
+	}
+
+	static void OnSudoDispatch_MkNod(BaseTransaction &bt)
+	{
+		std::string path;
+		mode_t mode;
+		dev_t dev;
+		bt.RecvStr(path);
+		bt.RecvPOD(mode);
+		bt.RecvPOD(dev);
+		int r = mknod(path.c_str(), mode, dev);
+		bt.SendInt(r);
+		if (r != 0) {
+			bt.SendErrno();
+		}
+	}
 
 	void OnSudoDispatch(SudoCommand cmd, BaseTransaction &bt)
 	{
@@ -449,6 +477,14 @@ namespace Sudo
 			case SUDO_CMD_FCHMOD:
 				OnSudoDispatch_FChMod(bt);
 				break;
+
+			case SUDO_CMD_MKFIFO:
+				OnSudoDispatch_MkFifo(bt);
+				break;
+
+			case SUDO_CMD_MKNOD:
+				OnSudoDispatch_MkNod(bt);
+				break;
 
 			default:
 				throw std::runtime_error("OnSudoDispatch - bad command");

WinPort/src/sudo/sudo_private.h

@@ -38,6 +38,8 @@ namespace Sudo
 		SUDO_CMD_FSFLAGSGET,
 		SUDO_CMD_FSFLAGSSET,
 		SUDO_CMD_FCHMOD,
+		SUDO_CMD_MKFIFO,
+		SUDO_CMD_MKNOD
 	};
 
 	class BaseTransaction

WinPort/sudo.h

@@ -72,6 +72,9 @@ extern "C" {
 	__attribute__ ((visibility("default"))) int sdc_fsetxattr(int fd, const char *name, const void *value, size_t size, int flags);
 	__attribute__ ((visibility("default"))) int sdc_fs_flags_get(const char *path, unsigned long *flags);
 	__attribute__ ((visibility("default"))) int sdc_fs_flags_set(const char *path, unsigned long flags);
+	__attribute__ ((visibility("default"))) int sdc_mkfifo(const char *path, mode_t mode);
+	__attribute__ ((visibility("default"))) int sdc_mknod(const char *path, mode_t mode, dev_t dev);
+
 #ifdef __cplusplus
 }
 

far2l/src/copy.cpp

@@ -2764,6 +2764,15 @@ DWORD ShellFileTransfer::PieceWrite(const void *Data, DWORD Size)
 
 /////////////////////////////////////////////////////////// END OF ShellFileTransfer
 
+static dev_t GetRDev(FARString SrcName)
+{
+    struct stat st{};
+    if (sdc_stat(SrcName.GetMB().c_str(), &st) == 0) {
+        return st.st_rdev;
+    }
+    return 0;
+}
+
 int ShellCopy::ShellCopyFile(const wchar_t *SrcName, const FAR_FIND_DATA_EX &SrcData, FARString &strDestName,
 		int Append)
 {
@@ -2778,6 +2787,16 @@ int ShellCopy::ShellCopyFile(const wchar_t *SrcName, const FAR_FIND_DATA_EX &Src
 			return (MkSymLink(SrcName, strDestName, RPT, true) ? COPY_SUCCESS : COPY_FAILURE);
 		}
 	}
+    if (SrcData.dwFileAttributes & (FILE_ATTRIBUTE_DEVICE_FIFO | FILE_ATTRIBUTE_DEVICE_BLOCK | FILE_ATTRIBUTE_DEVICE_CHAR)) {
+        int r = (SrcData.dwFileAttributes & FILE_ATTRIBUTE_DEVICE_FIFO)
+                    ? sdc_mkfifo(strDestName.GetMB().c_str(), SrcData.dwUnixMode)
+                    : sdc_mknod(strDestName.GetMB().c_str(), SrcData.dwUnixMode, GetRDev(SrcName));
+        if (r == -1) {
+            _localLastError = errno;
+            return COPY_FAILURE;
+        }
+        return COPY_SUCCESS;
+    }
 
 	try {
 #if defined(COW_SUPPORTED) && defined(__APPLE__)